1761834 - mach run -- --help on Windows does nothing

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect, P3)

Description

[:Gijs (he/him)]

It would be nice if bug 1175968 actually worked on Windows. For reference, the current state is:

$ ./mach run -- --help
 0:00.84 path/to/objdir\dist\bin\firefox.exe --help -no-remote -wait-for-browser -profile path\to\objdir\tmp\profile-default -attach-console

$

(yes, that's everything)

Comment 1

[Mike Hommey [:glandium]]

Does ./mach run -- --help | cat work?

Comment 2

[:Gijs (he/him)]

(In reply to Mike Hommey [:glandium] from comment #1)

Does ./mach run -- --help | cat work?

Yes.

Comment 3

[Mike Hommey [:glandium]]

The output in comment 0 says bug 1257155 still works, as -attach-console is there. So I guess that means there's a problem in Firefox's handling of -attach-console. I bet -help is handled before -attach-console.

Comment 4

[:Gijs (he/him)]

Attachment: Bug 1761834 - fix --help, --version and --full-version on Windows to actually work with console args, r?glandium

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf9c10546d59
fix --help, --version and --full-version on Windows to actually work with console args, r=glandium

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/cf9c10546d59