1761942 - [RDD] Limit maximal number of RDD process restart

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

Right now when RDD process crashes we restart it without any limit. That leads to many crashes / browser freeze etc. We need to set a threshold and throw a decoding error when it's hit.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1761942 [RDD] Limit maximal number of RDD process restarts r?alwu

Add media.rdd-process.max-crashes preference value to control how many times we restard RDD process before we throw decoding error message.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c2115cd9e0a80ba966d446d3aa0ebf491e152472

Comment 4

[Martin Stránský [:stransky] (ni? me)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b8a20a3151774e9709eea28e9490b97c29a8dc0

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f6ae1c1c198f
[RDD] Limit maximal number of RDD process restarts r=alwu

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f6ae1c1c198f

Comment 8

[Ciprian Georgiu, Desktop QA]

Hi Martin! Is this something that QA can manually verify, if so can you please provide us STR?

Comment 9

[Martin Stránský [:stransky] (ni? me)]

You can kill RDD process from terminal (kill -11 RDD_process_PID) until Firefox throws a message "media can't be played". You're supposed to do so twice and then Firefox should throw 'Unable to play media' message.