Closed Bug 1762030 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33410 - [@container] Perform LayoutUpgrade if any node skipped recalc

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
100 Branch
Tracking Status
firefox100 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33410 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33410
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:

[@container] Perform LayoutUpgrade if any node skipped recalc

Leaving nodes in a skipped state is not supported by our code,
at least not yet. NodeLayoutUpgrade::ShouldUpgrade did not take this
into account, and instead only checked for skipped nodes in the ancestor
chain. Upgrade whenever any node is in a skipped state instead.

This makes NodeLayoutUpgrade::UpgradeReason::kSkippedStyleRecalc
unnecessary, since we anyone only care about the StyleEngine-global
flag.

Fixed: 1306385
Bug: 1295717
Change-Id: I264c2d1b90e19135201ce4b319d7427960ba18e8
Reviewed-on: https://chromium-review.googlesource.com/3557374
WPT-Export-Revision: 9bf2aaa81214d6078e579eed60c03571928222d0

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/36bfa72280d0
[wpt PR 33410] - [@container] Perform LayoutUpgrade if any node skipped recalc, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.