1762030 - [wpt-sync] Sync PR 33410 - [@container] Perform LayoutUpgrade if any node skipped recalc

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 33410 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33410
Details from upstream follow.

Anders Hartvoll Ruud <[e-mail]> wrote:

[@container] Perform LayoutUpgrade if any node skipped recalc

Leaving nodes in a skipped state is not supported by our code,
at least not yet. NodeLayoutUpgrade::ShouldUpgrade did not take this
into account, and instead only checked for skipped nodes in the ancestor
chain. Upgrade whenever any node is in a skipped state instead.

This makes NodeLayoutUpgrade::UpgradeReason::kSkippedStyleRecalc
unnecessary, since we anyone only care about the StyleEngine-global
flag.

Fixed: 1306385
Bug: 1295717
Change-Id: I264c2d1b90e19135201ce4b319d7427960ba18e8
Reviewed-on: https://chromium-review.googlesource.com/3557374
WPT-Export-Revision: 9bf2aaa81214d6078e579eed60c03571928222d0

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=65bf10fdc1a09f49a3a7eda43370f4d200bfffe0

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36bfa72280d0
[wpt PR 33410] - [@container] Perform LayoutUpgrade if any node skipped recalc, a=testonly

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/36bfa72280d0