1762038 - Update to pylint v2.13.5

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Sylvestre Ledru [:Sylvestre]]

+++ This bug was initially created as a clone of Bug #1731749 +++

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1762038 - mozlint: Update to pylint v2.13.5 r?#linter-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18c5107d619f
mozlint: Update to pylint v2.13.4 r=linter-reviewers,ahal

Comment 3

[Iulian Moraru]

Backed out for causing py3 failures on test_vendor.py::test_up_to_date_vendor.

Push with failures

Failure log

Backout link

[task 2022-04-01T11:55:26.036Z] python/mozbuild/mozbuild/test/configure/test_toolchain_configure.py::OpenBSDToolchainTest::test_gcc
[task 2022-04-01T11:55:26.036Z]   /builds/worker/checkouts/gecko/python/mozbuild/mozbuild/preprocessor.py:863: DeprecationWarning: 'U' mode is deprecated
[task 2022-04-01T11:55:26.036Z]     args = io.open(args, "rU", encoding="utf-8")
[task 2022-04-01T11:55:26.036Z] 
[task 2022-04-01T11:55:26.036Z] -- Docs: https://docs.pytest.org/en/latest/warnings.html
[task 2022-04-01T11:55:26.036Z] ================== 54 passed, 562 warnings in 165.48 seconds ===================
[task 2022-04-01T11:55:26.036Z] 
[task 2022-04-01T11:55:26.036Z] 
[task 2022-04-01T11:55:26.036Z] Tests Completed: 100%|██████████| 77/77 [02:56<00:00, 29.83s/Test]
[task 2022-04-01T11:55:26.036Z]                                                                   
[task 2022-04-01T11:55:26.036Z] /builds/worker/checkouts/gecko/python/mozbuild/mozbuild/test/test_vendor.py
[task 2022-04-01T11:55:26.036Z] ============================= test session starts ==============================
[task 2022-04-01T11:55:26.037Z] platform linux -- Python 3.9.2, pytest-4.6.6, py-1.5.4, pluggy-0.13.1 -- /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/python-test/bin/python
[task 2022-04-01T11:55:26.037Z] rootdir: /builds/worker/checkouts/gecko, inifile: /builds/worker/checkouts/gecko/config/mozunit/mozunit/pytest.ini
[task 2022-04-01T11:55:26.037Z] collecting ... collected 1 item
[task 2022-04-01T11:55:26.037Z] 
[task 2022-04-01T11:55:26.037Z] python/mozbuild/mozbuild/test/test_vendor.py::test_up_to_date_vendor TEST-UNEXPECTED-FAIL
[task 2022-04-01T11:55:26.037Z] 
[task 2022-04-01T11:55:26.037Z] =================================== FAILURES ===================================
[task 2022-04-01T11:55:26.037Z] ____________________________ test_up_to_date_vendor ____________________________
[task 2022-04-01T11:55:26.037Z] python/mozbuild/mozbuild/test/test_vendor.py:36: in test_up_to_date_vendor
[task 2022-04-01T11:55:26.037Z]     subprocess.check_call(
[task 2022-04-01T11:55:26.037Z] /usr/lib/python3.9/subprocess.py:373: in check_call
[task 2022-04-01T11:55:26.037Z]     raise CalledProcessError(retcode, cmd)
[task 2022-04-01T11:55:26.037Z] E   subprocess.CalledProcessError: Command '['diff', '-r', '/builds/worker/checkouts/gecko/third_party/python', '/tmp/tmpg6_wmtrn/third_party/python', '--exclude=__pycache__']' returned non-zero exit status 1.
[task 2022-04-01T11:55:26.037Z] ----------------------------- Captured stdout call -----------------------------
[task 2022-04-01T11:55:26.037Z] Collecting aiohttp==3.7.4.post0
[task 2022-04-01T11:55:26.037Z]   Downloading aiohttp-3.7.4.post0.tar.gz (1.1 MB)
[task 2022-04-01T11:55:26.037Z]   Installing build dependencies: started
[task 2022-04-01T11:55:26.037Z]   Installing build dependencies: finished with status 'done'
[task 2022-04-01T11:55:26.037Z]   Getting requirements to build wheel: started
[task 2022-04-01T11:55:26.037Z]   Getting requirements to build wheel: finished with status 'done'
[task 2022-04-01T11:55:26.037Z]     Preparing wheel metadata: started
[task 2022-04-01T11:55:26.037Z]     Preparing wheel metadata: finished with status 'done'
[task 2022-04-01T11:55:26.037Z] Collecting appdirs==1.4.4
[task 2022-04-01T11:55:26.037Z]   Using cached appdirs-1.4.4-py2.py3-none-any.whl (9.6 kB)
[task 2022-04-01T11:55:26.037Z] Collecting async-timeout==3.0.1
[task 2022-04-01T11:55:26.037Z]   Using cached async_timeout-3.0.1-py3-none-any.whl (8.2 kB)
[task 2022-04-01T11:55:26.037Z] Collecting attrs==19.2.0
[task 2022-04-01T11:55:26.037Z]   Using cached attrs-19.2.0-py2.py3-none-any.whl (40 kB)
[task 2022-04-01T11:55:26.037Z] Collecting blessings==1.7
[task 2022-04-01T11:55:26.037Z]   Using cached blessings-1.7-py3-none-any.whl (18 kB)
[task 2022-04-01T11:55:26.037Z] Collecting cbor2==4.0.1
[task 2022-04-01T11:55:26.037Z]   Using cached cbor2-4.0.1-py2.py3-none-any.whl (11 kB)
[task 2022-04-01T11:55:26.037Z] Collecting certifi==2018.4.16
[task 2022-04-01T11:55:26.037Z]   Using cached certifi-2018.4.16-py2.py3-none-any.whl (150 kB)
[task 2022-04-01T11:55:26.037Z] Collecting chardet==4.0.0
[task 2022-04-01T11:55:26.037Z]   Using cached chardet-4.0.0-py2.py3-none-any.whl (178 kB)
<...>

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:Sylvestre, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

I will have a look at some point.

Comment 6

[Iulian Moraru]

Backed out for causing py3 failures.

Push with failures

For the first failures that appeared on autoland the failure summary is empty in treeherder.

Failure log for py3 mh jobs
Failure log for py3 tg jobs
Failure log for py3 mpu jobs

Backout link

Comment 7

[Takanori MATSUURA]

The latest version of pylint is 2.14.1 and the latest 2.13.x is 2.13.9.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9bfdf11040ff
mozlint: Update to pylint v2.13.5 r=linter-reviewers,ahal

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/9bfdf11040ff