1762059 - Trying to bootstrap without a VCS will lead to a endless loop instead of an error message

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, defect)

Description

[Malte Jürgens [:maltejur]]

To reproduce

1. Download Firefox Tarball from https://archive.mozilla.org/pub/firefox/releases/98.0.2/source/firefox-98.0.2.source.tar.xz
2. Run ./mach --no-interactive bootstrap --application-choice=browser
3. Be stuck in an endless loop after some time

Expected result

The error message:

Could not identify the root directory of your checkout!
Are you running mach bootstrap in an hg or git clone?

Notes

This is caused by https://bugzilla.mozilla.org/show_bug.cgi?id=1744884, more specifically this change: https://hg.mozilla.org/mozilla-central/diff/4aec4364abea6454e89ed977a147f311dfaaa95a/python/mozboot/mozboot/bootstrap.py#l1.323. Previously, the path was always split and thus shortened, until it is empty and the loop gets canceled. This now doesn't happen anymore, the path never gets modified, and the loop will run forever.

This whole thing isn't that big of a deal with the missing error message, but I could imagine that it can also cause some other issues.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1744884

Comment 2

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 1762059 - Resolved an infinite loop by updating the control variable to be one directory up (as it was before the Pathlib changes) r?#build

Comment 3

[Alex Hochheiden [:ahochheiden] [he/him]]

Thanks for the report!

The attached patch should resolve the issue.

I wasn't able to reproduce, but I ran the old code and new code side-by-side in my own little testing sandbox. The behaviour with my fix should be identical to the original behaviour now (before my Pathlib migration change introduced mistake).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22eae72d8c25
Resolved an infinite loop by updating the control variable to be one directory up (as it was before the Pathlib changes) r=firefox-build-system-reviewers,mhentges

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/22eae72d8c25