Closed Bug 1762109 Opened 2 years ago Closed 2 years ago

Make XLink handling on SVG/MathML consistent with styling.

Categories

(Core :: DOM: Core & HTML, defect)

defect

Tracking

()

RESOLVED FIXED
100 Branch
Tracking Status
firefox100 --- fixed

People

(Reporter: emilio, Assigned: emilio)

Details

Attachments

(1 file)

Styling uses the presence of href (ElementHasHref) to determine whether something is a link.

GetHrefURI does something quite different in most cases. For once xlink:href is disabled on MathML. And SVGAElement it has a bunch of weird preconditions to return a URI.

This should probably be consistent.

Also SVGAElement is the only thing overriding Link::ElementHasHref, but then it calls the base class explicitly instead of the virtual function. The only caller of SVGAElement::ElementHasHref is in SVGAFrame. Hilarious.

Make Link and SVGAElement agree on XLink handling, and make it more
explicit that SVGAElement needs to be a bit more special for SMIL.

Remove dead MathML XLink code.

Assignee: nobody → emilio
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cd9197fa716a
Make the XLink setup a bit saner. r=smaug
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/267c8d6766c9
Remove no longer needed method declaration.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: