1762111 - [wpt-sync] Sync PR 33414 - Add reflected IDL property for popup [popup 3/N]

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 33414 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33414
Details from upstream follow.

Mason Freed <[e-mail]> wrote:

Add reflected IDL property for popup [popup 3/N]

This CL just adds a Reflected popup IDL attribute for the
popup content attribute, plus associated testing.

Note: some existing web_tests/WPTs had to be modified slightly, to avoid
a namespace collision between global event handler content attributes
that called a function called "popup()", and the new 'popup' content
attribute. In those cases, the inline event handler runs with |this|
set to the element, so 'popup()' evaluates to 'this.popup()' which is
(now) an error due to the new 'popup' attribute. This might bode poorly
for general web compat - we'll see.

Bug: 1307772
Change-Id: I0218a1aa56f63c4965835b6457b3655bdf78aedd
Reviewed-on: https://chromium-review.googlesource.com/3556371
WPT-Export-Revision: f3501418865877b0a15a3bb9146a68a11dc804c9

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

PR 33414 applied with additional changes from upstream: 86e969bde149c09f055b2dcdf9ff0d8004cd8fd6, 704bea48e1e2bfc0295d4ee02a538e885e442aa1

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=d43e1dc9c4c07c87ae31addf69f109e629b704e8

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 9 subtests

Status Summary

Firefox

OK : 1
FAIL: 9

Chrome

OK : 1
FAIL: 9

Safari

OK : 1
FAIL: 9

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/semantics/popups/popup-attribute-basic.tentative.html
The .showPopup() and .hidePopup() work on a popup, case #0.: FAIL (Chrome: FAIL, Safari: FAIL)
The .showPopup() and .hidePopup() work on a popup, case #1.: FAIL (Chrome: FAIL, Safari: FAIL)
The .showPopup() and .hidePopup() work on a popup, case #2.: FAIL (Chrome: FAIL, Safari: FAIL)
The .showPopup() and .hidePopup() do NOT work on elements without a 'popup' attribute, case #0.: FAIL (Chrome: FAIL, Safari: FAIL)
The .showPopup() and .hidePopup() do NOT work on elements without a 'popup' attribute, case #1.: FAIL (Chrome: FAIL, Safari: FAIL)
The .showPopup() and .hidePopup() do NOT work on elements without a 'popup' attribute, case #2.: FAIL (Chrome: FAIL, Safari: FAIL)
IDL attribute reflection: FAIL (Chrome: FAIL, Safari: FAIL)
Changing attribute values for popup should work: FAIL (Chrome: FAIL, Safari: FAIL)
Popup attribute value should be case insensitive: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed6b00fe9c7c
[wpt PR 33414] - Add reflected IDL property for popup [popup 3/N], a=testonly
https://hg.mozilla.org/integration/autoland/rev/50285805cdca
[wpt PR 33414] - Update wpt metadata, a=testonly

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ed6b00fe9c7c
https://hg.mozilla.org/mozilla-central/rev/50285805cdca