1762141 - Firefox window cannot be dragged when in Customize toolbar page

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Giorgia Nichita, Release Desktop QA]

Attachment: dragwindow.gif

Affected versions

• Nightly 100.0a1
• Release 99.0

Affected platforms

• Windows 10 x64
• macOS 10.15
• Ubuntu 20.04

Steps to reproduce

1. Open Firefox.

2. Go to the Customize toolbar page.

3. Drag the Firefox window.

Expected result

• The window is draggable.

Actual result

• The window is not draggable.

Suggested Severity

• S4

Regression range

• https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3bab08d6ace5b39fe44b2a04c02a10b8048cf93f&tochange=ace96dd0c98b4fdc647db54b073b81ae90878fa9

Additional notes

• Gif attached to observe the issue.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1694546

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:Gijs, since you are the author of the regressor, bug 1694546, could you take a look?
For more information, please visit auto_nag documentation.

Comment 3

[:Gijs (he/him)]

The use of an exception for customizing windows stems from bug 944836.

There was always an exception for #titlebar, which I guess would fix the scenario in the screencast attached, but it was originally macOS-specific, and then got moved to the content browser.css (in bug 1122942) - and I removed it thinking it was superfluous given the XUL CSS. We can put it back, I guess? The xul.css instance has a titlebar selector but that doesn't actually apply to Firefox's browser window anymore...

Comment 4

[:Gijs (he/him)]

Attachment: Bug 1762141 - fix titlebar dragging in customize mode, r?emilio

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b77de0b524d8
fix titlebar dragging in customize mode, r=emilio

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b77de0b524d8

Comment 7

[Giorgia Nichita, Release Desktop QA]

Verified as fixed on latest Nightly 100.0a1 (20220401092803) on WIn 10 x64, Ubuntu 20.04 and macOS 10.15.