1762207 - remove hang_type

Status: RESOLVED FIXED

(Socorro :: Processor, task, P3)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

I was looking at the PluginRule and noticed the hang_type code makes no sense.

I investigated further and every single crash report indexed in Elasticsearch has a hang_type of 0.

hang_type is determined from the Hang and HangID annotations in this code:

https://github.com/mozilla-services/socorro/blob/20028cd706bb1308eafc6f3e34fdff1a2db1790a/socorro/processor/rules/mozilla.py#L263-L279

CrashAnnotations.yaml doesn't list either annotation. My skimming of mozilla-central suggests that it's not an omission in CrashAnnotations.yaml, but that neither are emitted in crash reports.

This bug covers verifying that the annotations aren't emitted and hang_type is not a thing and removing them.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Gabriele: Are Hang and HangID annotations emitted anymore? If not, I'll just remove this code.

Comment 2

[Gabriele Svelto [:gsvelto] (PTO)]

That's a very good question. I don't remember where those lived, I suppose it was in the Flash plugin code but I haven't seen them around in a while so I suspect they've been removed a long time ago. I'm going to dig in the history to see where they were gone.

Comment 3

[Gabriele Svelto [:gsvelto] (PTO)]

From what I can tell the HangID annotation was removed in bug 784145 over 10 years ago so I say it's safe to get rid of them :-)

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Thank you, Gabriele!

Grabbing this to remove them.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 6059: bug 1762207: remove hang_type

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #6059: "bug 1762207: remove hang_type" in 8fffe75.

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

This went to production in bug #1763234. Marking as FIXED.