Open Bug 1762227 Opened 3 years ago Updated 2 years ago

Investigate removing the strange about:blocked specialcase in ClickHandlerChild.jsm

Categories

(Toolkit :: Safe Browsing, defect, P3)

Desktop
All
defect

Tracking

()

Tracking Status
firefox100 --- affected

People

(Reporter: Gijs, Unassigned)

Details

In the early e10s days we added some strange click handling code specific to network error pages in bug 989875.

The handling for network error and blocked (safebrowsing) pages was then factored out in bug 1464552. As that happened, a bunch of the network error handling disappeared entirely from ClickHandlerChild.jsm. However, there is still a strange early return for about:blocked in there:

    // Handle click events from about pages
    if (event.button == 0) {
      if (ownerDoc.documentURI.startsWith("about:blocked")) {
        return;
      }
    }

It can probably be removed, but we should doublecheck.

Severity: -- → S4
Priority: -- → P3
Component: General → Safe Browsing
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.