1762263 - Add upgrade message on 100 major upgrade with single thank you (3 potential actions)

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Ed Lee :Mardak]

We can build in a message and configure it appropriately. This is different from the previous upgrade spotlights that relied on upgradeDialog code and instead can use the refactored multistage spotlight bug 1739252. Might want fancy title on colorway.

Comment 1

[Ed Lee :Mardak]

Unpinned users need a pin action. Not default gets a default action. Otherwise a single start browsing button that auto advance.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

My current speculation, without a lot of context looks like this:

We probably want to add the message, using a multistage template into the OnboardingProvider, and open the Spotlight dialoig in BrowserGlue.jsm, probably from or around _showUpgradeDialog.

I haven't self-assigned this bug, because I'm not far enough along that I think it makes sense for me to block anyone on the east coast from grabbing this if they want to in the morning. I'm happy to take it (or whatever is appropriate) Friday, of course. On the off-chance that it's useful, https://gist.github.com/dmose/a6829b5f64980609691bbefcd5e79a3f is the noodling that I've been doing that does not yet open a dialog...

Comment 3

[Meg Viar [:mviar]]

Attachment: Bug 1762263 - Add upgrade message on 100 major upgrade with single thank you (3 potential actions) r=Mardak

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3198ee2a85e
Add upgrade message on 100 major upgrade with single thank you (3 potential actions) r=Mardak

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e3198ee2a85e

Comment 6

[Morgan Reschenberg [:morgan]]

Hi! It looks like this dialog has a few accessibility issues:

• The animated logo is not disabled when a user has prefers-reduced-motion enabled
• The title text becomes invisible for high-contrast black themes, difficult to read on other high contrast dark themes
• Hitting tab initially focuses "not now" instead of the preferred "pin" button

I'll attach screenshots for the invisible text one.

Comment 7

[Morgan Reschenberg [:morgan]]

Attachment: upgrade_dialog_macOS_increase_contrast

Comment 8

[Morgan Reschenberg [:morgan]]

Attachment: upgrade_dialog_win_HCM_Night_Sky

Comment 9

[Meg Viar [:mviar]]

Thanks Morgan, I've file bug 1763470 to follow up on your findings.

Comment 10

[Meg Viar [:mviar]]

(disregard removing block)

Comment 11

[Simona Rosu [:srosu], Ecosystem QA]

This enhancement was part of the work done on QA-1448 for which we sent a Preliminary checkpoint. Considering this I am marking it as Verified.