Add PiP Video-Adapter for handling Dailymotion Subtitles
Categories
(Toolkit :: Picture-in-Picture, enhancement)
Tracking
()
People
(Reporter: admin, Assigned: admin, NeedInfo)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0
Steps to reproduce:
- Went on dailymotion.com
- Select a video
- Enable subtitles on built-in video player
- Click on PiP button
- Subtitles do not appear in PiP, only appear in built-in video player
(Some demo videos with subtitles)
Actual results:
Subtitles did not appear in the PiP window, they only displayed on the built-in video player.
Expected results:
Subtitles should appear in PiP.
|
||
Updated•2 years ago
|
|
||
Comment 2•2 years ago
|
||
(don't worry about the above changes, it's just some bookkeeping; thanks for filing this and submitting the patch!)
|
||
Updated•2 years ago
|
Pushed by kpatenio@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1a1c3dd13191 Add video wrapper with subtitle support for dailymotion.com. r=niklas,kpatenio
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
|
||
Updated•2 years ago
|
|
||
Comment 5•2 years ago
•
|
||
Verified as fixed on macOS 11.6, Windows 10 x64 and on Ubuntu 20.04 x64 on Firefox 102.0b3 and Nightly 103.0a1.
|
||
Comment 6•2 years ago
|
||
Apparently, due to website changes, the subtitles in PiP are no longer displayed for DailyMotion. This supposition was made because this occurs on all tested FF versions: Nightly v106.0a1 Release v104.0.2 and ESR v102.2.0esr.
This is an FYI. Let me know if it needs retesting or investigation.
Thank you for spotting this, Daniel.
Let me file a bug, and we'll hopefully be able to address it in 107, after the team is back from other projects.
Max, is there a chance you might have a moment to look at the changes and help us out with a patch update here?
Description
•