1762314 - [wpt-sync] Sync PR 33437 - Migrate focus handling logic from <popup> to Element [popup 7/7]

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 33437 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33437
Details from upstream follow.

Mason Freed <[e-mail]> wrote:

Migrate focus handling logic from <popup> to Element [popup 7/7]

This moves the focus management stuff out of HTMLPopupElement and into
Element, to work with both \<popup> and \<div popup>.

With this CL, all of the WPTs now pass, with the exception of the one
for the anchor IDL property, which is an open issue [1].

[1] https://github.com/openui/open-ui/issues/382

Bug: 1307772
Change-Id: I0f475b52b1a14a910d267c7b681327f2e08976ac

Reviewed-on: https://chromium-review.googlesource.com/3561291
WPT-Export-Revision: 4dbdbb59239c7440be430e4b1103521016e8f5af

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=96aedc8186be1f3479fb4b53534957feee2ce955

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 15 subtests

Status Summary

Firefox

OK : 1
FAIL: 15

Chrome

OK : 1
PASS: 3
FAIL: 12

Safari

OK : 1
FAIL: 15

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/semantics/popups/popup-focus.tentative.html
Popup focus test: default behavior - popup is not focused: FAIL (Chrome: PASS, Safari: FAIL)
Popup focus test: autofocus popup: FAIL (Chrome: FAIL, Safari: FAIL)
Popup focus test: autofocus empty popup: FAIL (Chrome: FAIL, Safari: FAIL)
Popup focus test: autofocus popup with button: FAIL (Chrome: FAIL, Safari: FAIL)
Popup focus test: autofocus child: FAIL (Chrome: FAIL, Safari: FAIL)
Popup focus test: autofocus on tabindex=0 element: FAIL (Chrome: FAIL, Safari: FAIL)
Popup focus test: autofocus multiple children: FAIL (Chrome: FAIL, Safari: FAIL)
Popup focus test: autofocus popup and multiple autofocus children: FAIL (Chrome: FAIL, Safari: FAIL)
Popup focus test: delegatesfocus popup: FAIL (Chrome: FAIL, Safari: FAIL)
Popup focus test: delegatesfocus takes precedence over autofocus: FAIL (Chrome: FAIL, Safari: FAIL)
Popup focus test: delegatesfocus takes precedence over autofocus 2: FAIL (Chrome: FAIL, Safari: FAIL)
Popup focus test: delegatesfocus on empty popup has no effect: FAIL (Chrome: PASS, Safari: FAIL)
Popup focus test: delegatesfocus on child has no effect: FAIL (Chrome: PASS, Safari: FAIL)
Popup focus test: delegatesfocus skips contained popups: FAIL (Chrome: FAIL, Safari: FAIL)
Popup focus test: delegatesfocus skips contained dialogs: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f5ab4458a77
[wpt PR 33437] - Migrate focus handling logic from <popup> to Element [popup 7/7], a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5f5ab4458a77