1762358 - The “Picture-in-Picture” icon is not visible on a profile enrolled in “Treatment G” branch - “PiP Icon Only”

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect)

Description

[Alice Varro [avarro], Ecosystem QA]

Attachment: Screen Recording 2022-03-31 at 12.06.52.mov

[Affected versions]:

• Firefox Release 99.0 en-CA/en-US/en-GB - Build ID: 20220328190900

[Affected Platforms]:

• Windows 10 x64
• macOS 12.3
• Linux Mint 20.2

[Prerequisites]:

• Have the Firefox 99.0 en-CA build or above installed.
• Have the user.js file saved on your computer.

[Steps to reproduce]:

1. Open the browser from prerequisites.
2. Enroll in the experiment by adding the user.js file into the profile folder and restart the browser.
3. Navigate to a video hosting service, (e.g. Youtube, Twitch) and interact with a video.
4. Observe the “PiP” icon displayed on the right-hand side area of the hosting service player.

[Expected result]:

• A gray button with the symbol of a square with an arrow pointed downwards is displayed on the right part of the video player.

[Actual result]:

• The “PiP” button is not visible on the video player.

[Notes]:

• The mouse cursor changes into a hand pointer, which indicates the presence of a button in the right-hand side area of the video player. The button is also actionable.
• This issue is reproducible only on profiles enrolled in the “Treatment G” branch.
• Attached is a screen recording of the issue:

Comment 1

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1762358 - Fixed PiP icon not visible on G branch of experiment. r=#pip-reviewers!

Comment 2

[Niklas Baumgardner [:niklas]]

Comment on attachment 9270264 [details]
Bug 1762358 - Fixed PiP icon not visible on G branch of experiment. r=#pip-reviewers!

Beta/Release Uplift Approval Request

• User impact if declined: Users enrolled in treatment branch G will not be able see the PiP toggle when hovering a video and data will be skewed from these users.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Enroll in the experiment by navigating to about:studies?optin_slug=picture-in-picture-first-time-toggle-text-ab&optin_branch=treatment-g&optin_collection=nimbus-preview

Make sure Picture-in-Picture is enabled and media.videocontrols.picture-in-picture.video-toggle.has-used is set to false in about:config.

Open www.youtube.com/watch?v=XdKzUbAiswE and hover the video. The PiP toggle should be visible.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Not risky because this only affects presentational behavior that is only invoked under experimental conditions branch G.
• String changes made/needed: No

Comment 3

[Donal Meehan [:dmeehan]]

:niklas for the beta uplift approval request - 99 is now in release, and the release candidate is ready to ship.
The S3 severity on this indicates like this could ride the train with 100? That's if it lands in central before next week's merge day on Monday, April 4.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fef38583d632
Fixed PiP icon not visible on G branch of experiment. r=pip-reviewers,mhowell

Comment 5

[Ania]

(In reply to Donal Meehan [:dmeehan] from comment #3)

:niklas for the beta uplift approval request - 99 is now in release, and the release candidate is ready to ship.
The S3 severity on this indicates like this could ride the train with 100? That's if it lands in central before next week's merge day on Monday, April 4.

Hi Donal,
The severity is indeed S3, but not shipping this ticket would result in postponing the experiment we were hoping to run (and that is otherwise ready) in 99. Is there a chance we can include this ticket or would it be too disruptive at this point?

Comment 6

[Donal Meehan [:dmeehan]]

(In reply to amininkova from comment #5)

The severity is indeed S3, but not shipping this ticket would result in postponing the experiment we were hoping to run (and that is otherwise ready) in 99. Is there a chance we can include this ticket or would it be too disruptive at this point?

Hi Ania, we are finalizing the 99 release.
Our release candidate has gone through QA and is ready for finalizing on Monday to go out on Tuesday.
This request falls outside the category of what we would take distributions for (e.g. not a release blocker)
We could review as a dot release ride along, if the beta uplift approval request is changed to a release uplift request.

Comment 7

[Niklas Baumgardner [:niklas]]

Comment on attachment 9270264 [details]
Bug 1762358 - Fixed PiP icon not visible on G branch of experiment. r=#pip-reviewers!

changing uplift request to release

Beta/Release Uplift Approval Request

• User impact if declined: Users enrolled in treatment branch G will not be able see the PiP toggle when hovering a video and data will be skewed from these users.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Enroll in the experiment by navigating to about:studies?optin_slug=picture-in-picture-first-time-toggle-text-ab&optin_branch=treatment-g&optin_collection=nimbus-preview

Make sure Picture-in-Picture is enabled and media.videocontrols.picture-in-picture.video-toggle.has-used is set to false in about:config.

Open www.youtube.com/watch?v=XdKzUbAiswE and hover the video. The PiP toggle should be visible.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Not risky because this only affects presentational behavior that is only invoked under experimental conditions branch G.
• String changes made/needed: No

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/fef38583d632

Comment 9

[Monica Chiorean]

Reproduced the issue without the fix on Win10x64 using build 99.0 en-CA.
Verified as fixed on Win10/Ubuntu20.4/Mac 10.13 using build 100.0a1_CA (20220403215202). On Win10 using 100.0a1_GB(20220404093932) and on Mac10.13 using 100.0a1_US(20220404093932).

Comment 10

[Donal Meehan [:dmeehan]]

Comment on attachment 9270264 [details]
Bug 1762358 - Fixed PiP icon not visible on G branch of experiment. r=#pip-reviewers!

Approved for 99.0.1.

Comment 11

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-release/rev/b4a9b8da5fbe

Comment 12

[Monica Chiorean]

Verified issue as fixed on Win10/Ubuntu20.4 using build 99.0.1 (20220411174855).