1762361 - Auto scroll broken in Virtualized Console panel

Status: RESOLVED WORKSFORME

(DevTools :: Console, defect)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I was testing the suport for virtulized Console panel and found one bug related to auto scroll to bottom. It might be known issue, but I am filing this bug anyways since there are specific STRs I found.

https://phabricator.services.mozilla.com/D138031

Feel free to close if/when this is fixed in the patch.

Here is my test case with instructions:
http://janodvarko.cz/tests/bugzilla/1762361/

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Another STRs (with the same test page as above) showing auto scroll issue:

1. Load http://janodvarko.cz/tests/bugzilla/1762361/
2. Open DevTools and select the Console panel
3. Click the Logs button on the page to generated 10K of logs
4. Scroll the content of the Console panel to the top
5. Click the Logs button again. At this point I can see how new logs are added to the content (i.e. as if the content was pinned to the bottom) and as soon as it's done the Console content is scrolled to the top. I think tha the content should stay at the top the entire time.

(Let me know if I should create a new bug report for those STRs)

Honza

Comment 2

[Alex Thayer [:alexical] (she/her)]

(In reply to Jan Honza Odvarko [:Honza] (always need-info? me) from comment #1)

Another STRs (with the same test page as above) showing auto scroll issue:

1. Load http://janodvarko.cz/tests/bugzilla/1762361/
2. Open DevTools and select the Console panel
3. Click the Logs button on the page to generated 10K of logs
4. Scroll the content of the Console panel to the top
5. Click the Logs button again. At this point I can see how new logs are added to the content (i.e. as if the content was pinned to the bottom) and as soon as it's done the Console content is scrolled to the top. I think tha the content should stay at the top the entire time.

(Let me know if I should create a new bug report for those STRs)

Honza

This one was a head scratcher, but it turns out it's just due to exactly aligning your log number with the devtools.hud.loglimit pref. If you change that pref to something else or change your logging amount to something else it's easier to see what's going on. We remain scrolled to the top, but we remove old entries as new ones come in, so you see the higher-numbered entries move to the top, until it all wraps around and you're back at 0 being the top.

The other one I can't reproduce, and I think it was fixed by a few fixups I made to make tests green.

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thank you for testing, Doug!

The other one I can't reproduce, and I think it was fixed by a few fixups I made to make tests green.

Do you have a Try build (exe binaries for Win10) including all your latest changes I could try to re-test this (and perhaps close) on my machine?

Comment 4

[Alex Thayer [:alexical] (she/her)]

(In reply to Jan Honza Odvarko [:Honza] (always need-info? me) from comment #3)

Thank you for testing, Doug!

The other one I can't reproduce, and I think it was fixed by a few fixups I made to make tests green.

Do you have a Try build (exe binaries for Win10) including all your latest changes I could try to re-test this (and perhaps close) on my machine?

Yup! This should do it:
Try run: https://treeherder.mozilla.org/jobs?repo=try&revision=d189ab424416b8bdd227b247c19ee5be8bdeae8f
Windows x64 binaries: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/PE3U7tzXSiSTViIm1umYtQ/runs/0/artifacts/public/build/target.zip

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:nchevobbe, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Honza, I think this can be closed right?

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I tested again and the issue is fixed, closing.
Thank you.