1762375 - [wpt-sync] Sync PR 33353 - [dPWA] Sub Apps - add code for remove() API

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 33353 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33353
Details from upstream follow.

Ivan Šandrk <[e-mail]> wrote:

[dPWA] Sub Apps - add code for remove() API

This CL adds the functionality for removing sub-apps that were added by
the parent app that is calling the API.

Sub Apps API enables PWAs to create multiple launch icons with distinct
names.

Design doc: go/multi-apps

Bug: 1171317
Change-Id: Ic518edccb91162a42f5c409456db6becc961283f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3307049
Reviewed-by: Jeremy Roman \<[e-mail]>
Reviewed-by: Robert Sesek \<[e-mail]>
Reviewed-by: Phillis Tang \<[e-mail]>
Reviewed-by: Daniel Murphy \<[e-mail]>
Commit-Queue: Ivan Šandrk \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#987396}

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=3bb3bf637fb38f9010888bb4d6ec75c3f5d6673a

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS : 13
FAIL : 22
ERROR: 2

Chrome

OK : 1
PASS : 13
FAIL : 22
ERROR: 2

Safari

OK : 1
PASS : 13
FAIL : 22
ERROR: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/subapps/idlharness.tentative.https.window.html
SubApps interface: existence and properties of interface object: FAIL (Chrome: FAIL, Safari: FAIL)
SubApps interface object length: FAIL (Chrome: FAIL, Safari: FAIL)
SubApps interface object name: FAIL (Chrome: FAIL, Safari: FAIL)
SubApps interface: existence and properties of interface prototype object: FAIL (Chrome: FAIL, Safari: FAIL)
SubApps interface: existence and properties of interface prototype object's "constructor" property: FAIL (Chrome: FAIL, Safari: FAIL)
SubApps interface: existence and properties of interface prototype object's @@unscopables property: FAIL (Chrome: FAIL, Safari: FAIL)
SubApps interface: operation add(DOMString): FAIL (Chrome: FAIL, Safari: FAIL)
SubApps interface: operation list(): FAIL (Chrome: FAIL, Safari: FAIL)
SubApps interface: operation remove(DOMString): FAIL (Chrome: FAIL, Safari: FAIL)
SubApps must be primary interface of navigator.subApps: FAIL (Chrome: FAIL, Safari: FAIL)
Stringification of navigator.subApps: FAIL (Chrome: FAIL, Safari: FAIL)
SubApps interface: navigator.subApps must inherit property "add(DOMString)" with the proper type: FAIL (Chrome: FAIL, Safari: FAIL)
SubApps interface: calling add(DOMString) on navigator.subApps with too few arguments must throw TypeError: FAIL (Chrome: FAIL, Safari: FAIL)
SubApps interface: navigator.subApps must inherit property "list()" with the proper type: FAIL (Chrome: FAIL, Safari: FAIL)
SubApps interface: navigator.subApps must inherit property "remove(DOMString)" with the proper type: FAIL (Chrome: FAIL, Safari: FAIL)
SubApps interface: calling remove(DOMString) on navigator.subApps with too few arguments must throw TypeError: FAIL (Chrome: FAIL, Safari: FAIL)
Navigator interface: attribute subApps: FAIL (Chrome: FAIL, Safari: FAIL)
Navigator interface: navigator must inherit property "subApps" with the proper type: FAIL (Chrome: FAIL, Safari: FAIL)
/subapps/remove-error.tentative.https.html: ERROR (Chrome: ERROR, Safari: ERROR)
The object is no longer associated to a document.: FAIL (Chrome: FAIL, Safari: FAIL)
API is only supported in top-level browsing contexts.: FAIL (Chrome: FAIL, Safari: FAIL)
Remove call failed.: FAIL (Chrome: FAIL, Safari: FAIL)
/subapps/remove-success.tentative.https.html: ERROR (Chrome: ERROR, Safari: ERROR)
Remove API call works.: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a79701bed981
[wpt PR 33353] - [dPWA] Sub Apps - add code for remove() API, a=testonly
https://hg.mozilla.org/integration/autoland/rev/60f64b33c6c1
[wpt PR 33353] - Update wpt metadata, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a79701bed981
https://hg.mozilla.org/mozilla-central/rev/60f64b33c6c1