Closed Bug 1762434 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33454 - [Cookie Expires/Max-Age Upper Limit] (3) Enable by default

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox102 fixed)

Status:
RESOLVED FIXED
Milestone:
102 Branch
Tracking Flags:
Tracking Status
firefox102 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33454 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33454
Details from upstream follow.

Ari Chivukula <arichiv@chromium.org> wrote:

[Cookie Expires/Max-Age Upper Limit] (3) Enable by default

Now that we're shipping this, we should vet the 'on by default' state.

This CL is a part of a series:
(1) Add new UMA
(2) Implement limit behind flag
(3) Enable by default

Spec:
https://github.com/httpwg/http-extensions/pull/1732

Bug: 1264458
Change-Id: Idc0469d260c4a5706a9c64feec9af5a0f490d311
Reviewed-on: https://chromium-review.googlesource.com/3561385
WPT-Export-Revision: de2776943688ffce185143704e94600f7a9ba7b6

Whiteboard: [wptsync downstream] → [wptsync downstream error]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 10 subtests

Status Summary

Firefox

OK : 2
FAIL: 20

Chrome

OK : 2
PASS: 16
FAIL: 4

Safari

OK : 2
FAIL: 20

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /cookie-store/cookieListItem_attributes.https.any.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: OK)
    • CookieListItem - cookieStore.set defaults with positional name and value: FAIL (Chrome: PASS, Safari: FAIL)
    • CookieListItem - cookieStore.set defaults with name and value in options: FAIL (Chrome: PASS, Safari: FAIL)
    • CookieListItem - cookieStore.set with expires set to a timestamp 10 years in the future: FAIL (Chrome: FAIL, Safari: FAIL)
    • CookieListItem - cookieStore.set with expires set to a Date 10 years in the future: FAIL (Chrome: FAIL, Safari: FAIL)
    • CookieListItem - cookieStore.set with domain set to the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
    • CookieListItem - cookieStore.set with path set to the current directory: FAIL (Chrome: PASS, Safari: FAIL)
    • CookieListItem - cookieStore.set adds / to path if it does not end with /: FAIL (Chrome: PASS, Safari: FAIL)
    • CookieListItem - cookieStore.set with sameSite set to strict: FAIL (Chrome: PASS, Safari: FAIL)
    • CookieListItem - cookieStore.set with sameSite set to lax: FAIL (Chrome: PASS, Safari: FAIL)
    • CookieListItem - cookieStore.set with sameSite set to none: FAIL (Chrome: PASS, Safari: FAIL)
  • /cookie-store/cookieListItem_attributes.https.any.serviceworker.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: OK)
    • CookieListItem - cookieStore.set defaults with positional name and value: FAIL (Chrome: PASS, Safari: FAIL)
    • CookieListItem - cookieStore.set defaults with name and value in options: FAIL (Chrome: PASS, Safari: FAIL)
    • CookieListItem - cookieStore.set with expires set to a timestamp 10 years in the future: FAIL (Chrome: FAIL, Safari: FAIL)
    • CookieListItem - cookieStore.set with expires set to a Date 10 years in the future: FAIL (Chrome: FAIL, Safari: FAIL)
    • CookieListItem - cookieStore.set with domain set to the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
    • CookieListItem - cookieStore.set with path set to the current directory: FAIL (Chrome: PASS, Safari: FAIL)
    • CookieListItem - cookieStore.set adds / to path if it does not end with /: FAIL (Chrome: PASS, Safari: FAIL)
    • CookieListItem - cookieStore.set with sameSite set to strict: FAIL (Chrome: PASS, Safari: FAIL)
    • CookieListItem - cookieStore.set with sameSite set to lax: FAIL (Chrome: PASS, Safari: FAIL)
    • CookieListItem - cookieStore.set with sameSite set to none: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

  • /cookie-store/cookieListItem_attributes.https.any.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: OK)
  • /cookie-store/cookieListItem_attributes.https.any.serviceworker.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: OK)
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/00adc2035860
[wpt PR 33454] - [Cookie Expires/Max-Age Upper Limit] (3) Enable by default, a=testonly
Whiteboard: [wptsync downstream error] → [wptsync downstream]

https://hg.mozilla.org/mozilla-central/rev/00adc2035860

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox102: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.