Closed Bug 1762462 Opened 8 months ago Closed 5 months ago

Tests do not reflect Always Partitioning Storage

Categories

(Core :: Privacy: Anti-Tracking, defect, P2)

defect

Tracking

()

RESOLVED FIXED
104 Branch
Tracking Status
firefox104 --- fixed

People

(Reporter: bvandersloot, Assigned: bvandersloot)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxatps-always-partition-storage] )

Attachments

(16 files, 7 obsolete files)

48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
No description provided.
Assignee: nobody → bvandersloot
Status: NEW → ASSIGNED

These are draft test changes to update antitracking tests so that storage is not unpartitioned on storage access grant

Severity: -- → S3
Priority: -- → P2
Pushed by bvandersloot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a3024e8b2a58
Tests do not reflect Always Partitioning Storage, r=twisniewski
Pushed by bvandersloot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fa222c0a9a26
Tests do not reflect Always Partitioning Storage, r=twisniewski

Backed out for causing mochitest failures on test_storagePermissionsAccept.html

Flags: needinfo?(bvandersloot)

Alright, i think I've managed to fix the test breakage now, as far as I can tell: https://treeherder.mozilla.org/jobs?repo=try&revision=f299ddc811373cdc43d8abf60529ddbf399cee2b&selectedTaskRun=D00ZNQMfTFus4o6gmvTjwg.0

I'll try landing this patchset again soon.

Flags: needinfo?(bvandersloot)
Attachment #9273878 - Attachment description: Bug 1762462 - Tests do not reflect Always Partitioning Storage, r=twisniewski! → Bug 1762462 - Make tests in toolkit/components/antitracking/ reflect Always Partitioning Storage; r?bvandersloot
Attachment #9270292 - Attachment is obsolete: true
Attachment #9279309 - Attachment is obsolete: true
Attachment #9279296 - Attachment is obsolete: true
Attachment #9279313 - Attachment is obsolete: true
Attachment #9279314 - Attachment is obsolete: true
Attachment #9279300 - Attachment is obsolete: true
Attachment #9272776 - Attachment is obsolete: true
Attachment #9279298 - Attachment description: Bug 1762462 - Make tests in browser/base/content/test/protectionsUI/ reflect Always Partitioning Storage; r?mossop → Bug 1762462 - Make tests in browser/base/content/test/protectionsUI/ reflect Always Partitioning Storage; r?mossop!
Attachment #9279299 - Attachment description: Bug 1762462 - Make tests in devtools/client/storage/test/ reflect Always Partitioning Storage; r?jdescottes → Bug 1762462 - Make tests in devtools/client/storage/test/ reflect Always Partitioning Storage; r?jdescottes!
Attachment #9279302 - Attachment description: Bug 1762462 - Make tests in docshell/test/mochitest/ reflect Always Partitioning Storage; r?smaug → Bug 1762462 - Make tests in docshell/test/mochitest/ reflect Always Partitioning Storage; r?smaug!
Attachment #9279303 - Attachment description: Bug 1762462 - Make tests in docshell/test/navigation/ reflect Always Partitioning Storage; r?smaug → Bug 1762462 - Make tests in docshell/test/navigation/ reflect Always Partitioning Storage; r?smaug!
Attachment #9279305 - Attachment description: Bug 1762462 - Make tests in dom/broadcastchannel/tests/ reflect Always Partitioning Storage; r?smaug → Bug 1762462 - Make tests in dom/broadcastchannel/tests/ reflect Always Partitioning Storage; r?smaug!
Attachment #9279306 - Attachment description: Bug 1762462 - Make tests in dom/cache/test/mochitest/ reflect Always Partitioning Storage; r?asuth → Bug 1762462 - Make tests in dom/cache/test/mochitest/ reflect Always Partitioning Storage; r?asuth!
Attachment #9279307 - Attachment description: Bug 1762462 - Make tests in dom/indexedDB/test/unit/ reflect Always Partitioning Storage; r?baku → Bug 1762462 - Make tests in dom/indexedDB/test/unit/ reflect Always Partitioning Storage; r?baku!
Attachment #9279308 - Attachment description: Bug 1762462 - Make tests in dom/ipc/tests/ reflect Always Partitioning Storage; r?nika → Bug 1762462 - Make tests in dom/ipc/tests/ reflect Always Partitioning Storage; r?nika!
Attachment #9279312 - Attachment description: Bug 1762462 - Make tests in dom/tests/browser/ reflect Always Partitioning Storage; r?nika → Bug 1762462 - Make tests in dom/tests/browser/ reflect Always Partitioning Storage; r?nika!
Attachment #9279315 - Attachment description: Bug 1762462 - Make tests in dom/tests/mochitest/sessionstorage/ reflect Always Partitioning Storage; r?asuth → Bug 1762462 - Make tests in dom/tests/mochitest/sessionstorage/ reflect Always Partitioning Storage; r?asuth!
Attachment #9279317 - Attachment description: Bug 1762462 - Make tests in dom/workers/test/ reflect Always Partitioning Storage; r?smaug → Bug 1762462 - Make tests in dom/workers/test/ reflect Always Partitioning Storage; r?smaug!
Attachment #9279318 - Attachment description: Bug 1762462 - Make tests in layout/base/tests/ reflect Always Partitioning Storage; r?smaug → Bug 1762462 - Make tests in layout/base/tests/ reflect Always Partitioning Storage; r?smaug!
Attachment #9279319 - Attachment description: Bug 1762462 - Disable Always Partitioning Storage pref for Web Platform Tests; r?bvandersloot → Bug 1762462 - Disable Always Partitioning Storage pref for Web Platform Tests; r?bvandersloot!
Attachment #9273878 - Attachment description: Bug 1762462 - Make tests in toolkit/components/antitracking/ reflect Always Partitioning Storage; r?bvandersloot → Bug 1762462 - Make tests in toolkit/components/antitracking/ reflect Always Partitioning Storage; r?bvandersloot!
Attachment #9284740 - Attachment description: Bug 1762462 - Make tests in dom/websocket/tests/ reflect Always Partitioning Storage; r?honza → Bug 1762462 - Make tests in dom/websocket/tests/ reflect Always Partitioning Storage; r?honza!
Attachment #9284741 - Attachment description: Bug 1762462 - Make tests in toolkit/components/extensions/test/ reflect Always Partitioning Storage; r?rpl → Bug 1762462 - Make tests in toolkit/components/extensions/test/ reflect Always Partitioning Storage; r?rpl!
Pushed by bvandersloot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/31a70f9ad879
Make tests in browser/base/content/test/protectionsUI/ reflect Always Partitioning Storage; r=mossop
https://hg.mozilla.org/integration/autoland/rev/21dd6fdc672e
Make tests in devtools/client/storage/test/ reflect Always Partitioning Storage; r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/edb94ba8ec59
Make tests in docshell/test/mochitest/ reflect Always Partitioning Storage; r=smaug
https://hg.mozilla.org/integration/autoland/rev/73ed8be3f117
Make tests in docshell/test/navigation/ reflect Always Partitioning Storage; r=smaug
https://hg.mozilla.org/integration/autoland/rev/2615b571c9ba
Make tests in dom/broadcastchannel/tests/ reflect Always Partitioning Storage; r=smaug
https://hg.mozilla.org/integration/autoland/rev/01504f5f818a
Make tests in dom/cache/test/mochitest/ reflect Always Partitioning Storage; r=asuth
https://hg.mozilla.org/integration/autoland/rev/81eb7d60dea9
Make tests in dom/indexedDB/test/unit/ reflect Always Partitioning Storage; r=timhuang
https://hg.mozilla.org/integration/autoland/rev/4f8aaba02a03
Make tests in dom/ipc/tests/ reflect Always Partitioning Storage; r=nika
https://hg.mozilla.org/integration/autoland/rev/d66dd76ec2b6
Make tests in dom/tests/browser/ reflect Always Partitioning Storage; r=nika
https://hg.mozilla.org/integration/autoland/rev/64df67f43ad7
Make tests in dom/tests/mochitest/sessionstorage/ reflect Always Partitioning Storage; r=asuth
https://hg.mozilla.org/integration/autoland/rev/fa3c45b4de5c
Make tests in dom/workers/test/ reflect Always Partitioning Storage; r=smaug
https://hg.mozilla.org/integration/autoland/rev/92cec5f5db1c
Make tests in layout/base/tests/ reflect Always Partitioning Storage; r=smaug
https://hg.mozilla.org/integration/autoland/rev/1e81ed3014a0
Disable Always Partitioning Storage pref for Web Platform Tests; r=bvandersloot
https://hg.mozilla.org/integration/autoland/rev/6249efe40513
Make tests in toolkit/components/antitracking/ reflect Always Partitioning Storage; r=timhuang
https://hg.mozilla.org/integration/autoland/rev/b7d979a36324
Make tests in dom/websocket/tests/ reflect Always Partitioning Storage; r=baku
https://hg.mozilla.org/integration/autoland/rev/a27ae15872a9
Make tests in toolkit/components/extensions/test/ reflect Always Partitioning Storage; r=mixedpuppy

Backed out for causing mochitest failures on test_storage_copied

Backout link

Push with failures

Failure log // Failure log 2

Flags: needinfo?(bvandersloot)
Depends on: 1779603
Pushed by bvandersloot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/619e4bb01a81
Make tests in browser/base/content/test/protectionsUI/ reflect Always Partitioning Storage; r=mossop
https://hg.mozilla.org/integration/autoland/rev/707f9dfed501
Make tests in devtools/client/storage/test/ reflect Always Partitioning Storage; r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/e5e0655206a8
Make tests in docshell/test/mochitest/ reflect Always Partitioning Storage; r=smaug
https://hg.mozilla.org/integration/autoland/rev/cbd69786a24b
Make tests in docshell/test/navigation/ reflect Always Partitioning Storage; r=smaug
https://hg.mozilla.org/integration/autoland/rev/a88a099c684d
Make tests in dom/broadcastchannel/tests/ reflect Always Partitioning Storage; r=smaug
https://hg.mozilla.org/integration/autoland/rev/030c276d6669
Make tests in dom/cache/test/mochitest/ reflect Always Partitioning Storage; r=asuth
https://hg.mozilla.org/integration/autoland/rev/0cf191a7739f
Make tests in dom/indexedDB/test/unit/ reflect Always Partitioning Storage; r=timhuang
https://hg.mozilla.org/integration/autoland/rev/acf08a10c6fb
Make tests in dom/ipc/tests/ reflect Always Partitioning Storage; r=nika
https://hg.mozilla.org/integration/autoland/rev/74539a3cc7fc
Make tests in dom/tests/browser/ reflect Always Partitioning Storage; r=nika
https://hg.mozilla.org/integration/autoland/rev/92bd237a95e1
Make tests in dom/tests/mochitest/sessionstorage/ reflect Always Partitioning Storage; r=asuth
https://hg.mozilla.org/integration/autoland/rev/7c99293cc8f9
Make tests in dom/workers/test/ reflect Always Partitioning Storage; r=smaug
https://hg.mozilla.org/integration/autoland/rev/0c760428dfec
Make tests in layout/base/tests/ reflect Always Partitioning Storage; r=smaug
https://hg.mozilla.org/integration/autoland/rev/ffbf90e3bbab
Disable Always Partitioning Storage pref for Web Platform Tests; r=bvandersloot
https://hg.mozilla.org/integration/autoland/rev/8f11221f859f
Make tests in toolkit/components/antitracking/ reflect Always Partitioning Storage; r=timhuang
https://hg.mozilla.org/integration/autoland/rev/00c0c6314640
Make tests in dom/websocket/tests/ reflect Always Partitioning Storage; r=baku
https://hg.mozilla.org/integration/autoland/rev/4e46a6f209b4
Make tests in toolkit/components/extensions/test/ reflect Always Partitioning Storage; r=mixedpuppy

Backed out for causing mochitest failures on browser_partitionedConsoleMessage.js

Resolving a race condition in browser_partitionedConsoleMessage.js. Once that is confirmed fixed, and a try run looks clean, I will re-land.

Flags: needinfo?(bvandersloot)
Pushed by bvandersloot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/edd09ecd2fce
Make tests in browser/base/content/test/protectionsUI/ reflect Always Partitioning Storage; r=mossop
https://hg.mozilla.org/integration/autoland/rev/e22432c9ab23
Make tests in devtools/client/storage/test/ reflect Always Partitioning Storage; r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/f6ccd3f2992b
Make tests in docshell/test/mochitest/ reflect Always Partitioning Storage; r=smaug
https://hg.mozilla.org/integration/autoland/rev/a339485a41e9
Make tests in docshell/test/navigation/ reflect Always Partitioning Storage; r=smaug
https://hg.mozilla.org/integration/autoland/rev/5dbbaf893944
Make tests in dom/broadcastchannel/tests/ reflect Always Partitioning Storage; r=smaug
https://hg.mozilla.org/integration/autoland/rev/2da01c611f83
Make tests in dom/cache/test/mochitest/ reflect Always Partitioning Storage; r=asuth
https://hg.mozilla.org/integration/autoland/rev/d54a6a1bc2eb
Make tests in dom/indexedDB/test/unit/ reflect Always Partitioning Storage; r=timhuang
https://hg.mozilla.org/integration/autoland/rev/f71182dd4063
Make tests in dom/ipc/tests/ reflect Always Partitioning Storage; r=nika
https://hg.mozilla.org/integration/autoland/rev/d847ce3e5f43
Make tests in dom/tests/browser/ reflect Always Partitioning Storage; r=nika
https://hg.mozilla.org/integration/autoland/rev/20db1f2fae5d
Make tests in dom/tests/mochitest/sessionstorage/ reflect Always Partitioning Storage; r=asuth
https://hg.mozilla.org/integration/autoland/rev/58038cac0c8f
Make tests in dom/workers/test/ reflect Always Partitioning Storage; r=smaug
https://hg.mozilla.org/integration/autoland/rev/b6a5a2ae3bc4
Make tests in layout/base/tests/ reflect Always Partitioning Storage; r=smaug
https://hg.mozilla.org/integration/autoland/rev/054f1d3c841a
Disable Always Partitioning Storage pref for Web Platform Tests; r=bvandersloot
https://hg.mozilla.org/integration/autoland/rev/b1b6b08482e1
Make tests in toolkit/components/antitracking/ reflect Always Partitioning Storage; r=timhuang
https://hg.mozilla.org/integration/autoland/rev/4efc7cc18534
Make tests in dom/websocket/tests/ reflect Always Partitioning Storage; r=baku
https://hg.mozilla.org/integration/autoland/rev/8f23067c327c
Make tests in toolkit/components/extensions/test/ reflect Always Partitioning Storage; r=mixedpuppy
Regressions: 1779881
You need to log in before you can comment on or make changes to this bug.