1762462 - Tests do not reflect Always Partitioning Storage

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect, P2)

Comment 1

[Benjamin VanderSloot [:bvandersloot]]

Attachment: WIP: Bug 1762462 - Tests do not reflect Always Partitioning Storage, WIP

These are draft test changes to update antitracking tests so that storage is not unpartitioned on storage access grant

Comment 2

[Thomas Wisniewski [:twisniewski]]

Attachment: WIP: Bug 1762462 - Tests do not reflect Always Partitioning Storage, WIP

Depends on D143627

Comment 3

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1762462 - Make tests in toolkit/components/antitracking/ reflect Always Partitioning Storage; r?bvandersloot!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3024e8b2a58
Tests do not reflect Always Partitioning Storage, r=twisniewski

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa222c0a9a26
Tests do not reflect Always Partitioning Storage, r=twisniewski

Comment 6

[Cristian Tuns]

Backed out for causing mochitest failures on test_storagePermissionsAccept.html

• Backout link
• Push with failures
• Failure Log
• Failure Log2
• Failure Log3
• Failure Log4
• Failure line: TEST-UNEXPECTED-FAIL | dom/tests/mochitest/general/test_storagePermissionsAccept.html | getting localStorage should not throw

Comment 7

[Thomas Wisniewski [:twisniewski]]

Alright, i think I've managed to fix the test breakage now, as far as I can tell: https://treeherder.mozilla.org/jobs?repo=try&revision=f299ddc811373cdc43d8abf60529ddbf399cee2b&selectedTaskRun=D00ZNQMfTFus4o6gmvTjwg.0

I'll try landing this patchset again soon.

Comment 8

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1762462 - Make tests in browser/base/content/test/favicons/ reflect Always Partitioning Storage; r?mossop

Depends on D143627

Comment 9

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1762462 - Make tests in browser/base/content/test/protectionsUI/ reflect Always Partitioning Storage; r?mossop!

Depends on D148041

Comment 10

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1762462 - Make tests in devtools/client/storage/test/ reflect Always Partitioning Storage; r?jdescottes!

Depends on D148042

Comment 11

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1762462 - Make tests in devtools/client/webconsole/test/ reflect Always Partitioning Storage; r?jdescottes

Depends on D148043

Comment 12

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1762462 - Make tests in docshell/test/mochitest/ reflect Always Partitioning Storage; r?smaug!

Depends on D148044

Comment 13

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1762462 - Make tests in docshell/test/navigation/ reflect Always Partitioning Storage; r?smaug!

Depends on D148046

Comment 14

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1762462 - Make tests in dom/broadcastchannel/tests/ reflect Always Partitioning Storage; r?smaug!

Depends on D148047

Comment 15

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1762462 - Make tests in dom/cache/test/mochitest/ reflect Always Partitioning Storage; r?asuth!

Depends on D148048

Comment 16

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1762462 - Make tests in dom/indexedDB/test/unit/ reflect Always Partitioning Storage; r?baku!

Depends on D148049

Comment 17

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1762462 - Make tests in dom/ipc/tests/ reflect Always Partitioning Storage; r?nika!

Depends on D148050

Comment 18

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1762462 - Make tests in dom/locks/test/ reflect Always Partitioning Storage; r?saschanaz

Depends on D148051

Comment 19

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1762462 - Make tests in dom/tests/browser/ reflect Always Partitioning Storage; r?nika!

Depends on D148052

Comment 20

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1762462 - Make tests in dom/tests/mochitest/bugs/ reflect Always Partitioning Storage; r?asuth

Depends on D148054

Comment 21

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1762462 - Make tests in dom/tests/mochitest/fetch/ reflect Always Partitioning Storage; r?asuth

Depends on D148055

Comment 22

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1762462 - Make tests in dom/tests/mochitest/sessionstorage/ reflect Always Partitioning Storage; r?asuth!

Depends on D148056

Comment 23

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1762462 - Make tests in dom/workers/test/ reflect Always Partitioning Storage; r?smaug!

Depends on D148057

Comment 24

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1762462 - Make tests in layout/base/tests/ reflect Always Partitioning Storage; r?smaug!

Depends on D148058

Comment 25

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1762462 - Disable Always Partitioning Storage pref for Web Platform Tests; r?bvandersloot!

Depends on D148059

Comment 26

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1762462 - Make tests in dom/websocket/tests/ reflect Always Partitioning Storage; r?honza!

Depends on D144731

Comment 27

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1762462 - Make tests in toolkit/components/extensions/test/ reflect Always Partitioning Storage; r?rpl!

Depends on D151393

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31a70f9ad879
Make tests in browser/base/content/test/protectionsUI/ reflect Always Partitioning Storage; r=mossop
https://hg.mozilla.org/integration/autoland/rev/21dd6fdc672e
Make tests in devtools/client/storage/test/ reflect Always Partitioning Storage; r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/edb94ba8ec59
Make tests in docshell/test/mochitest/ reflect Always Partitioning Storage; r=smaug
https://hg.mozilla.org/integration/autoland/rev/73ed8be3f117
Make tests in docshell/test/navigation/ reflect Always Partitioning Storage; r=smaug
https://hg.mozilla.org/integration/autoland/rev/2615b571c9ba
Make tests in dom/broadcastchannel/tests/ reflect Always Partitioning Storage; r=smaug
https://hg.mozilla.org/integration/autoland/rev/01504f5f818a
Make tests in dom/cache/test/mochitest/ reflect Always Partitioning Storage; r=asuth
https://hg.mozilla.org/integration/autoland/rev/81eb7d60dea9
Make tests in dom/indexedDB/test/unit/ reflect Always Partitioning Storage; r=timhuang
https://hg.mozilla.org/integration/autoland/rev/4f8aaba02a03
Make tests in dom/ipc/tests/ reflect Always Partitioning Storage; r=nika
https://hg.mozilla.org/integration/autoland/rev/d66dd76ec2b6
Make tests in dom/tests/browser/ reflect Always Partitioning Storage; r=nika
https://hg.mozilla.org/integration/autoland/rev/64df67f43ad7
Make tests in dom/tests/mochitest/sessionstorage/ reflect Always Partitioning Storage; r=asuth
https://hg.mozilla.org/integration/autoland/rev/fa3c45b4de5c
Make tests in dom/workers/test/ reflect Always Partitioning Storage; r=smaug
https://hg.mozilla.org/integration/autoland/rev/92cec5f5db1c
Make tests in layout/base/tests/ reflect Always Partitioning Storage; r=smaug
https://hg.mozilla.org/integration/autoland/rev/1e81ed3014a0
Disable Always Partitioning Storage pref for Web Platform Tests; r=bvandersloot
https://hg.mozilla.org/integration/autoland/rev/6249efe40513
Make tests in toolkit/components/antitracking/ reflect Always Partitioning Storage; r=timhuang
https://hg.mozilla.org/integration/autoland/rev/b7d979a36324
Make tests in dom/websocket/tests/ reflect Always Partitioning Storage; r=baku
https://hg.mozilla.org/integration/autoland/rev/a27ae15872a9
Make tests in toolkit/components/extensions/test/ reflect Always Partitioning Storage; r=mixedpuppy

Comment 29

[Norisz Fay [:noriszfay]]

Backed out for causing mochitest failures on test_storage_copied

Backout link

Push with failures

Failure log // Failure log 2

Comment 30

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/619e4bb01a81
Make tests in browser/base/content/test/protectionsUI/ reflect Always Partitioning Storage; r=mossop
https://hg.mozilla.org/integration/autoland/rev/707f9dfed501
Make tests in devtools/client/storage/test/ reflect Always Partitioning Storage; r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/e5e0655206a8
Make tests in docshell/test/mochitest/ reflect Always Partitioning Storage; r=smaug
https://hg.mozilla.org/integration/autoland/rev/cbd69786a24b
Make tests in docshell/test/navigation/ reflect Always Partitioning Storage; r=smaug
https://hg.mozilla.org/integration/autoland/rev/a88a099c684d
Make tests in dom/broadcastchannel/tests/ reflect Always Partitioning Storage; r=smaug
https://hg.mozilla.org/integration/autoland/rev/030c276d6669
Make tests in dom/cache/test/mochitest/ reflect Always Partitioning Storage; r=asuth
https://hg.mozilla.org/integration/autoland/rev/0cf191a7739f
Make tests in dom/indexedDB/test/unit/ reflect Always Partitioning Storage; r=timhuang
https://hg.mozilla.org/integration/autoland/rev/acf08a10c6fb
Make tests in dom/ipc/tests/ reflect Always Partitioning Storage; r=nika
https://hg.mozilla.org/integration/autoland/rev/74539a3cc7fc
Make tests in dom/tests/browser/ reflect Always Partitioning Storage; r=nika
https://hg.mozilla.org/integration/autoland/rev/92bd237a95e1
Make tests in dom/tests/mochitest/sessionstorage/ reflect Always Partitioning Storage; r=asuth
https://hg.mozilla.org/integration/autoland/rev/7c99293cc8f9
Make tests in dom/workers/test/ reflect Always Partitioning Storage; r=smaug
https://hg.mozilla.org/integration/autoland/rev/0c760428dfec
Make tests in layout/base/tests/ reflect Always Partitioning Storage; r=smaug
https://hg.mozilla.org/integration/autoland/rev/ffbf90e3bbab
Disable Always Partitioning Storage pref for Web Platform Tests; r=bvandersloot
https://hg.mozilla.org/integration/autoland/rev/8f11221f859f
Make tests in toolkit/components/antitracking/ reflect Always Partitioning Storage; r=timhuang
https://hg.mozilla.org/integration/autoland/rev/00c0c6314640
Make tests in dom/websocket/tests/ reflect Always Partitioning Storage; r=baku
https://hg.mozilla.org/integration/autoland/rev/4e46a6f209b4
Make tests in toolkit/components/extensions/test/ reflect Always Partitioning Storage; r=mixedpuppy

Comment 31

[Cristian Tuns]

Backed out for causing mochitest failures on browser_partitionedConsoleMessage.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | toolkit/components/antitracking/test/browser/browser_partitionedConsoleMessage.js | Test timed out -

Comment 32

[Benjamin VanderSloot [:bvandersloot]]

Resolving a race condition in browser_partitionedConsoleMessage.js. Once that is confirmed fixed, and a try run looks clean, I will re-land.

Comment 33

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/edd09ecd2fce
Make tests in browser/base/content/test/protectionsUI/ reflect Always Partitioning Storage; r=mossop
https://hg.mozilla.org/integration/autoland/rev/e22432c9ab23
Make tests in devtools/client/storage/test/ reflect Always Partitioning Storage; r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/f6ccd3f2992b
Make tests in docshell/test/mochitest/ reflect Always Partitioning Storage; r=smaug
https://hg.mozilla.org/integration/autoland/rev/a339485a41e9
Make tests in docshell/test/navigation/ reflect Always Partitioning Storage; r=smaug
https://hg.mozilla.org/integration/autoland/rev/5dbbaf893944
Make tests in dom/broadcastchannel/tests/ reflect Always Partitioning Storage; r=smaug
https://hg.mozilla.org/integration/autoland/rev/2da01c611f83
Make tests in dom/cache/test/mochitest/ reflect Always Partitioning Storage; r=asuth
https://hg.mozilla.org/integration/autoland/rev/d54a6a1bc2eb
Make tests in dom/indexedDB/test/unit/ reflect Always Partitioning Storage; r=timhuang
https://hg.mozilla.org/integration/autoland/rev/f71182dd4063
Make tests in dom/ipc/tests/ reflect Always Partitioning Storage; r=nika
https://hg.mozilla.org/integration/autoland/rev/d847ce3e5f43
Make tests in dom/tests/browser/ reflect Always Partitioning Storage; r=nika
https://hg.mozilla.org/integration/autoland/rev/20db1f2fae5d
Make tests in dom/tests/mochitest/sessionstorage/ reflect Always Partitioning Storage; r=asuth
https://hg.mozilla.org/integration/autoland/rev/58038cac0c8f
Make tests in dom/workers/test/ reflect Always Partitioning Storage; r=smaug
https://hg.mozilla.org/integration/autoland/rev/b6a5a2ae3bc4
Make tests in layout/base/tests/ reflect Always Partitioning Storage; r=smaug
https://hg.mozilla.org/integration/autoland/rev/054f1d3c841a
Disable Always Partitioning Storage pref for Web Platform Tests; r=bvandersloot
https://hg.mozilla.org/integration/autoland/rev/b1b6b08482e1
Make tests in toolkit/components/antitracking/ reflect Always Partitioning Storage; r=timhuang
https://hg.mozilla.org/integration/autoland/rev/4efc7cc18534
Make tests in dom/websocket/tests/ reflect Always Partitioning Storage; r=baku
https://hg.mozilla.org/integration/autoland/rev/8f23067c327c
Make tests in toolkit/components/extensions/test/ reflect Always Partitioning Storage; r=mixedpuppy

Comment 34

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/edd09ecd2fce
https://hg.mozilla.org/mozilla-central/rev/e22432c9ab23
https://hg.mozilla.org/mozilla-central/rev/f6ccd3f2992b
https://hg.mozilla.org/mozilla-central/rev/a339485a41e9
https://hg.mozilla.org/mozilla-central/rev/5dbbaf893944
https://hg.mozilla.org/mozilla-central/rev/2da01c611f83
https://hg.mozilla.org/mozilla-central/rev/d54a6a1bc2eb
https://hg.mozilla.org/mozilla-central/rev/f71182dd4063
https://hg.mozilla.org/mozilla-central/rev/d847ce3e5f43
https://hg.mozilla.org/mozilla-central/rev/20db1f2fae5d
https://hg.mozilla.org/mozilla-central/rev/58038cac0c8f
https://hg.mozilla.org/mozilla-central/rev/b6a5a2ae3bc4
https://hg.mozilla.org/mozilla-central/rev/054f1d3c841a
https://hg.mozilla.org/mozilla-central/rev/b1b6b08482e1
https://hg.mozilla.org/mozilla-central/rev/4efc7cc18534
https://hg.mozilla.org/mozilla-central/rev/8f23067c327c