1762474 - [css-conditional-3] Make conditionText readonly

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Mozilla Apprentice]

A resolution was made for csswg-drafts/#6819.

[css-conditional-3] Setting .conditionText interop is terrible

• RESOLVED: Make conditionText readonly

Discussion.

Comment 1

[Daniel Holbert [:dholbert]]

As noted in https://github.com/w3c/csswg-drafts/issues/6819#issue-1055502312, Firefox supports setting conditionText (as the spec used to require) for @media rules.

Now, per the above-quoted resolution, conditionText is supposed to be read-only, so we should not support setting it.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: testcase 1

Here's a testcase, from a simplification of a WPT test that fantasai wrote. (Note: I think her WPT test was expecting conditionText to be writable and hence is no longer valid.)

For this attached test, the STR are:

1. View the test directly in your browser.

EXPECTED RESULTS: lime div
ACTUAL RESULTS: red div

(If the test renders as red, then that indicates that it successfully modified the condition of the media query, even though it wasn't supposed to be able to.)

Comment 3

[Daniel Holbert [:dholbert]]

A fix here will probably need to include a new WPT test; I'm not immediately finding any WPT test-failure annotations (in .ini files in searchfox) that mention conditionText, at least.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1762474 - Make CSSConditionRule.conditionText readonly. r=#layout-reviewers,#style

Depends on D143192

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a588f6d08f7
Make CSSConditionRule.conditionText readonly. r=layout-reviewers,firefox-style-system-reviewers,boris

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/33558 for changes under testing/web-platform/tests

Comment 7

[Atila Butkovits]

Backed out for causing failures at test_interfaces.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/341746177149043a5e0a8f31d2632071b42abf02

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=eNfCGBq8RV-iARNG5cLJCg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=6a588f6d08f795ffc8594a01250e3ae3307bde92

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=373815640&repo=autoland&lineNumber=7618

https://treeherder.mozilla.org/logviewer?job_id=373819459&repo=autoland&lineNumber=2929

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c5ac0c99219
Make CSSConditionRule.conditionText readonly. r=layout-reviewers,firefox-style-system-reviewers,boris

Comment 10

[Atila Butkovits]

Backed out for causing failures at idlharness.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/ed124d06d67623a6227a41ecffd8533733755976

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=6c5ac0c99219dfa6396841f69b13c47e3e559c37&selectedTaskRun=aeEeINcnREmzqmfdO25Dpg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=373840721&repo=autoland&lineNumber=5588

Comment 11

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99a576b86767
Make CSSConditionRule.conditionText readonly. r=layout-reviewers,firefox-style-system-reviewers,boris

Comment 13

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/99a576b86767

Comment 14

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot