1762547 - Building firefox with gpsd support on ubuntu 20.04 fail

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[franz.angeli]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/98.0.4758.102 Safari/537.36

Steps to reproduce:

compile from source with --enable-gpsd

Actual results:

building fail with:

"ERROR: Package libgps was not found in the pkg-config search path"

but i have libgps installed (also libgps.-dev) and on pkg-config path

Expected results:

gpsd working

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox Build System::General' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

You should have more details in the log, no ?

Comment 3

[franz.angeli]

(In reply to Sylvestre Ledru [:Sylvestre] from comment #2)

You should have more details in the log, no ?

0:05.95 ERROR: Package libgps was not found in the pkg-config search path.
0:05.95 ERROR: Perhaps you should add the directory containing `libgps.pc'
0:05.95 ERROR: to the PKG_CONFIG_PATH environment variable
0:05.95 ERROR: Package 'libgps', required by 'virtual:world', not found
*** Fix above errors and then restart with "./mach build"

pkg-config --variable pc_path pkg-config
/usr/local/lib/x86_64-linux-gnu/pkgconfig:/usr/local/lib/pkgconfig:/usr/local/share/pkgconfig:/usr/lib/x86_64-linux-gnu/pkgconfig:/usr/lib/pkgconfig:/usr/share/pkgconfig

and i have libgps.pc in /usr/lib/x86_64-linux-gnu/pkgconfig/libgps.pc

juniper@*****:~/Downloads/mozilla-unified$ cat /usr/lib/x86_64-linux-gnu/pkgconfig/libgps.pc
prefix=/usr
exec_prefix=${prefix}
libdir=/usr/lib/x86_64-linux-gnu
includedir=/usr/include

Name: GPSD
Description: GPS Daemon communication library
Version: 3.20
Cflags: -I${includedir}
Libs: -L${libdir} -lgps

Comment 4

[Mitchell Hentges [:mhentges] 🦀]

I don't have access to a linux machine today to repro and diagnose this, but I can recommend some next steps for debugging what's going on for your system:

1. Share on this bug the obj-*/config.log file, as it has more helpful information.
2. Here's the code that executes pkg-config
3. You can add some code before get_cmd_output() to print which pkg-config is being run, and with which args:

        # Using `log.error()` so it shows up in regular `./mach configure` output
        log.error("pkg_config={}, package_desc={}".format(pkg_config, package_desc))
        retcode, ... = ...

Comment 5

[franz.angeli]

Attachment: config.log

Comment 6

[Mitchell Hentges [:mhentges] 🦀]

Executing: `/home/juniper/.mozbuild/pkgconf/pkg-config --errors-to-stdout --print-errors 'libgps >= 3.11'`
INFO: no

Looks like we're using our own pkg-config instead of your system one.
What's the output of /home/juniper/.mozbuild/pkgconf/pkg-config --variable pc_path pkg-config?

Comment 7

[franz.angeli]

(In reply to Mitchell Hentges [:mhentges] 🦀 from comment #4)

I don't have access to a linux machine today to repro and diagnose this, but I can recommend some next steps for debugging what's going on for your system:

1. Share on this bug the obj-*/config.log file, as it has more helpful information.
2. Here's the code that executes pkg-config
3. You can add some code before get_cmd_output() to print which pkg-config is being run, and with which args:

        # Using `log.error()` so it shows up in regular `./mach configure` output
        log.error("pkg_config={}, package_desc={}".format(pkg_config, package_desc))
        retcode, ... = ...

attached config.log(In reply to Mitchell Hentges [:mhentges] 🦀 from comment #6)

Executing: `/home/juniper/.mozbuild/pkgconf/pkg-config --errors-to-stdout --print-errors 'libgps >= 3.11'`
INFO: no

Looks like we're using our own pkg-config instead of your system one.
What's the output of /home/juniper/.mozbuild/pkgconf/pkg-config --variable pc_path pkg-config?

juniper@****:~/Downloads/mozilla-unified$ /home/juniper/.mozbuild/pkgconf/pkg-config --variable pc_path pkg-config
/usr/local/lib/pkgconfig:/usr/local/share/pkgconfig

Comment 8

[franz.angeli]

(In reply to Mitchell Hentges [:mhentges] 🦀 from comment #6)

Executing: `/home/juniper/.mozbuild/pkgconf/pkg-config --errors-to-stdout --print-errors 'libgps >= 3.11'`
INFO: no

Looks like we're using our own pkg-config instead of your system one.
What's the output of /home/juniper/.mozbuild/pkgconf/pkg-config --variable pc_path pkg-config?

juniper@*****:~/Downloads/mozilla-unified$ /home/juniper/.mozbuild/pkgconf/pkg-config --variable pc_path pkg-config
/usr/local/lib/pkgconfig:/usr/local/share/pkgconfig

Comment 9

[Mitchell Hentges [:mhentges] 🦀]

Looks like our managed pkg-config is missing the /usr/local/lib/x86_64-linux-gnu/pkgconfig path. I'll NI :glandium as he might have some guesses as to why.

Workaround

Add export PKG_CONFIG_PATH=/usr/local/lib/x86_64-linux-gnu/pkgconfig:/usr/local/lib/pkgconfig:/usr/local/share/pkgconfig:/usr/lib/x86_64-linux-gnu/pkgconfig:/usr/lib/pkgconfig:/usr/share/pkgconfig to your mozconfig file and try again.

Comment 10

[franz.angeli]

Attachment: config.log after export

Comment 11

[franz.angeli]

(In reply to Mitchell Hentges [:mhentges] 🦀 from comment #9)

Looks like our managed pkg-config is missing the /usr/local/lib/x86_64-linux-gnu/pkgconfig path. I'll NI :glandium as he might have some guesses as to why.

Workaround

Add export PKG_CONFIG_PATH=/usr/local/lib/x86_64-linux-gnu/pkgconfig:/usr/local/lib/pkgconfig:/usr/local/share/pkgconfig:/usr/lib/x86_64-linux-gnu/pkgconfig:/usr/lib/pkgconfig:/usr/share/pkgconfig to your mozconfig file and try again.

i try adding path to mozconfig:

juniper@******:~/Downloads/mozilla-unified$ cat mozconfig
ac_add_options --enable-gpsd

export PKG_CONFIG_PATH=/usr/local/lib/x86_64-linux-gnu/pkgconfig:/usr/local/lib/pkgconfig:/usr/local/share/pkgconfig:/usr/lib/x86_64-linux-gnu/pkgconfig:/usr/lib/pkgconfig:/usr/share/pkgconfig

but mach configure fail in the same way:

0:04.36 checking for libgps >= 3.11... no
0:04.36 ERROR: Package libgps was not found in the pkg-config search path.
0:04.36 ERROR: Perhaps you should add the directory containing `libgps.pc'
0:04.36 ERROR: to the PKG_CONFIG_PATH environment variable
0:04.36 ERROR: Package 'libgps', required by 'virtual:world', not found
*** Fix above errors and then restart with "./mach build"

if i set on shell

export PKG_CONFIG_PATH...

juniper@****:~/.mozbuild/pkgconf$ /home/juniper/.mozbuild/pkgconf/pkg-config --libs libgps
-L/usr/lib/x86_64-linux-gnu -lgps

but command on config.log return nothing

juniper@:~/Downloads/mozilla-unified/obj-x86_64-pc-linux-gnu$ /home/juniper/.mozbuild/pkgconf/pkg-config --errors-to-stdout --print-errors 'libgps >= 3.11'
juniper@:~/Downloads/mozilla-unified/obj-x86_64-pc-linux-gnu$

Comment 12

[Mitchell Hentges [:mhentges] 🦀]

juniper@:~/Downloads/mozilla-unified/obj-x86_64-pc-linux-gnu$ /home/juniper/.mozbuild/pkgconf/pkg-config --errors-to-stdout --print-errors 'libgps >= 3.11'

Hmm, that's promising: looking again, I'm guessing that this is related to sysroot shenanigans. I'm not sure the right way to use external libraries, and how that relates to usage of the sysroot, so I think the person most equipped to progress this is glandium.

Comment 13

[franz.angeli]

(In reply to Mitchell Hentges [:mhentges] 🦀 from comment #12)

juniper@:~/Downloads/mozilla-unified/obj-x86_64-pc-linux-gnu$ /home/juniper/.mozbuild/pkgconf/pkg-config --errors-to-stdout --print-errors 'libgps >= 3.11'

Hmm, that's promising: looking again, I'm guessing that this is related to sysroot shenanigans. I'm not sure the right way to use external libraries, and how that relates to usage of the sysroot, so I think the person most equipped to progress this is glandium.

using on mozconfig:

ac_add_options --without-sysroot

i'm able to compile with gpsd support....but it seems not working...

i've added string in about:confing

geo.location.use_gpsd true

but it seems not work...

Comment 14

[Mike Hommey [:glandium]]

So there are two problems:

• --enable-gpsd should barf when using the sysroot, because that's not supported.
• it doesn't work. Considering we've never shipped with this enabled, that's not really a surprise. I'd suggest filing a separate bug under Core::DOM: Geolocation.

Comment 15

[Mike Hommey [:glandium]]

Attachment: Bug 1762547 - Make --enable-gpsd a system_lib_option.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d70943042496
Make --enable-gpsd a system_lib_option. r=firefox-build-system-reviewers,mhentges

Comment 17

[franz.angeli]

ok with your patch:

0:04.57 ERROR: --enable-gpsd is not supported with bootstrapped sysroot. Drop the option, or use --without-sysroot or --disable-bootstrap
*** Fix above errors and then restart with "./mach build"

i've opened another bug for GPSD not working (1763347)

Thanks

Comment 18

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/d70943042496