1762588 - Perma browser/components/places/tests/browser/browser_bookmark_context_menu_contents.js | Context menu option placesContext_open:newcontainertab is visible - false == true - JS frame :: chrome://mochitests/content/br Gecko 100 merges to Beta on 2022-04-04

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Iulian Moraru]

[Tracking Requested - why for this release]:

Central-as-beta simulation:
How to run these simulations:

Failure log:

[task 2022-04-01T12:17:44.726Z] 12:17:44     INFO - TEST-START | browser/components/places/tests/browser/browser_bookmark_context_menu_contents.js
[task 2022-04-01T12:17:45.057Z] 12:17:45     INFO - TEST-INFO | started process screentopng
[task 2022-04-01T12:17:45.476Z] 12:17:45     INFO - TEST-INFO | screentopng: exit 0
[task 2022-04-01T12:17:45.477Z] 12:17:45     INFO - Buffered messages logged at 12:17:44
[task 2022-04-01T12:17:45.477Z] 12:17:45     INFO - Entering setup bound 
[task 2022-04-01T12:17:45.478Z] 12:17:45     INFO - Leaving setup bound 
[task 2022-04-01T12:17:45.478Z] 12:17:45     INFO - Entering test bound test_bookmark_contextmenu_contents
[task 2022-04-01T12:17:45.484Z] 12:17:45     INFO - Buffered messages logged at 12:17:45
[task 2022-04-01T12:17:45.484Z] 12:17:45     INFO - TEST-PASS | browser/components/places/tests/browser/browser_bookmark_context_menu_contents.js | Context menu contains the menuitem placesContext_open:newtab - {"renderedOnce":true,"_accelTextIsDerived":true,"_ignoreAccelTextChange":true,"_inheritedElements":{".menu-iconic-text":null,".menu-text":{"_lastFormattedAccessKey":null},".menu-iconic-highlightable-text":null},"initializedAttributeInheritance":true} == true - 
[task 2022-04-01T12:17:45.484Z] 12:17:45     INFO - TEST-PASS | browser/components/places/tests/browser/browser_bookmark_context_menu_contents.js | Context menu option placesContext_open:newtab is visible - true == true - 
[task 2022-04-01T12:17:45.484Z] 12:17:45     INFO - TEST-PASS | browser/components/places/tests/browser/browser_bookmark_context_menu_contents.js | Context menu contains the menuitem placesContext_open:newcontainertab - {"isRunningDelayedConnectedCallback":false,"renderedOnce":true,"_inheritedElements":{".menubar-text":null,".menu-iconic-text":null,".menu-text":{"_lastFormattedAccessKey":null},".menu-iconic-highlightable-text":null,".menu-right":{}},"initializedAttributeInheritance":true} == true - 
[task 2022-04-01T12:17:45.484Z] 12:17:45     INFO - Buffered messages finished
[task 2022-04-01T12:17:45.484Z] 12:17:45     INFO - TEST-UNEXPECTED-FAIL | browser/components/places/tests/browser/browser_bookmark_context_menu_contents.js | Context menu option placesContext_open:newcontainertab is visible - false == true - JS frame :: chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_bookmark_context_menu_contents.js :: OptionItemExists :: line 51
[task 2022-04-01T12:17:45.484Z] 12:17:45     INFO - Stack trace:
[task 2022-04-01T12:17:45.484Z] 12:17:45     INFO - chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_bookmark_context_menu_contents.js:OptionItemExists:51
[task 2022-04-01T12:17:45.484Z] 12:17:45     INFO - chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_bookmark_context_menu_contents.js:checkContextMenu:90
[task 2022-04-01T12:17:45.484Z] 12:17:45     INFO - TEST-PASS | browser/components/places/tests/browser/browser_bookmark_context_menu_contents.js | Context menu contains the menuitem placesContext_open:newwindow - {"renderedOnce":true,"_accelTextIsDerived":true,"_ignoreAccelTextChange":true,"_inheritedElements":{".menu-iconic-text":null,".menu-text":{"_lastFormattedAccessKey":null},".menu-iconic-highlightable-text":null},"initializedAttributeInheritance":true} == true - 
[task 2022-04-01T12:17:45.485Z] 12:17:45     INFO - TEST-PASS | browser/components/places/tests/browser/browser_bookmark_context_menu_contents.js | Context menu option placesContext_open:newwindow is visible - true == true - 

Comment 1

[Iulian Moraru]

Hi Masatoshi! Can you please take a look at this? I think this started from your recent changes in Bug 1754805.

Comment 2

[Masatoshi Kimura [:emk]]

Attachment: Bug 1762588 - Handle the case where userContextId is disabled. r?mcheang,mak

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65a03d2dd25d
Handle the case where userContextId is disabled. r=mak

Comment 4

[Masatoshi Kimura [:emk]]

Attachment: Bug 1762588 - Follow-up: using spread syntax. r?mcheang,mak

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/65a03d2dd25d

Comment 6

[Andreea Pavel [:apavel]]

Verified fixed in latest beta sim: https://treeherder.mozilla.org/jobs?repo=try&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=93a0cfdd7928661aa0b306edcb7058886f519033&searchStr=browser%2Cchrome&group_state=expanded