1762688 - Implement nsIImapService in JavaScript

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, task)

Comment 1

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Init ImapModuleLoader.jsm to prepare for rewriting IMAP in JS. r=mkmelin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0a13350f24d4
Init ImapModuleLoader.jsm to prepare for rewriting IMAP in JS. r=mkmelin

Comment 3

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Remove unused outURL from addMessageFlags/subtractMessageFlags in nsIImapService.idl. r=mkmelin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c7ac3e90e9e3
Remove unused outURL from addMessageFlags/subtractMessageFlags in nsIImapService.idl. r=mkmelin

Comment 5

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Init ImapProtocolHandler.jsm and ImapChannel.jsm to handle imap: url. r=mkmelin

Comment 6

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Implement ImapChannel to read msg from local cache or server. r=mkmelin

Depends on D146037.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2942ebf0617a
Init ImapProtocolHandler.jsm and ImapChannel.jsm to handle imap: url. r=mkmelin
https://hg.mozilla.org/comm-central/rev/6e19373da115
Implement ImapChannel to read msg from local cache or server. r=mkmelin

Comment 8

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Remove some unused nsIURI return values in nsIImapService.idl. r=mkmelin

Comment 9

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Support renaming folder in ImapService.jsm. r=mkmelin

Depends on D147398.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/58998a2b70cc
Remove some unused nsIURI return values in nsIImapService.idl. r=mkmelin

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1a04609c926a
Support renaming folder in ImapService.jsm. r=mkmelin

Comment 12

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Enable test_mailboxes for imap-js. r=mkmelin

Handle folder name with space and non-ascii characters.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/61c1d85191bd
Enable test_mailboxes for imap-js. r=mkmelin

Comment 14

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Init ImapMessageService.jsm and implement SaveMessageToDisk. r=mkmelin

Enable three tests.

Comment 15

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Implement expunge/onlineCopy in ImapService.jsm. r=mkmelin

• Remove unused return value of nsIImapService.expunge
• Implement streamMessage in ImapMessageService.jsm
• Enable test_compactOfflineStore.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dfb8a2f8aa67
Init ImapMessageService.jsm and implement SaveMessageToDisk. r=mkmelin
https://hg.mozilla.org/comm-central/rev/8305a158c2ac
Implement expunge/onlineCopy in ImapService.jsm. r=mkmelin

Comment 17

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Reuse local cache in ImapClient to fix test_bug460636 in debug build. r=mkmelin

If a message is already in local cache, no need to fetch from server again.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c03ef5d91db4
Reuse local cache in ImapClient to fix test_bug460636 in debug build. r=mkmelin

Comment 19

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Implement ensureFolderExists and appendMessageFromFile in ImapService.jsm. r=mkmelin

Enable test_copyThenMove.js.

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b4b5992f4a22
Implement ensureFolderExists and appendMessageFromFile in ImapService.jsm. r=mkmelin

Comment 21

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Implement updateFolderStatus and GetNewMessagesForNonInboxFolders in imap-js. r=mkmelin

Enable test_dontStatNoSelect.js.

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/63b80b2a4306
Implement updateFolderStatus and GetNewMessagesForNonInboxFolders in imap-js. r=mkmelin

Comment 23

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Implement fetchCustomMsgAttribute in ImapService.jsm. r=mkmelin

Enable test_fetchCustomAttribute.js.

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/928e0f0d0270
Implement fetchCustomMsgAttribute in ImapService.jsm. r=mkmelin

Comment 25

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Enable test_gmailOfflineMsgStore and test_imapAttachmentSaves for imap-js. r=mkmelin

Implement DisplayMessage in ImapMessageService.jsm.

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b74b284c0d23
Enable test_gmailOfflineMsgStore and test_imapAttachmentSaves for imap-js. r=mkmelin

Comment 27

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Enable test_imapContentLength.js for imap-js. r=mkmelin

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a4a9bf7ba074
Enable test_imapContentLength.js for imap-js. r=mkmelin

Comment 29

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Enable test_imapCopyTimeout.js for imap-js. r=mkmelin

Comment 30

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/69ecda475f78
Enable test_imapCopyTimeout.js for imap-js. r=mkmelin

Comment 31

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Enable test_imapFilterActions.js for imap-js. r=mkmelin,benc

Implement ImapMessageService.CopyMessage and ImapService.storeCustomKeywords.

Comment 32

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Use nsIImapFlagAndUidState interfaces instead of GetFlagsForUID in nsImapMailFolder. r=mkmelin,benc

Comment 33

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/90c1dc256e94
Use nsIImapFlagAndUidState interfaces instead of GetFlagsForUID in nsImapMailFolder. r=mkmelin
https://hg.mozilla.org/comm-central/rev/70c31d20e192
Enable test_imapFilterActions.js for imap-js. r=mkmelin

Comment 34

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Enable test_imapFolderCopy.js for imap-js. r=mkmelin,benc

Implement ImapService.moveFolder.

Comment 35

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6667b938be74
Enable test_imapFolderCopy.js for imap-js. r=mkmelin,benc

Comment 36

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Enable test_imapHdrStreaming.js for imap-js. r=mkmelin,benc

Implement ImapMessageService.streamHeaders.

Comment 37

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Enable test_imapID.js and test_imapClientid.js for imap-js. r=mkmelin,benc

Comment 38

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a688af168e20
Enable test_imapHdrStreaming.js for imap-js. r=mkmelin
https://hg.mozilla.org/comm-central/rev/918dc805e302
Enable test_imapID.js and test_imapClientid.js for imap-js. r=mkmelin

Comment 39

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Enable test_imapStoreMsgOffline for imap-js. r=mkmelin,benc

Implement ImapService.downloadMessagesForOffline.

Comment 40

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8b0633a05616
Enable test_imapStoreMsgOffline for imap-js. r=mkmelin

Comment 41

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Disable test_imapStatusCloseDBs.js for imap-js. r=mkmelin,benc

Comment 42

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/030305f9fb4c
Disable test_imapStatusCloseDBs.js for imap-js. r=mkmelin,benc

Comment 43

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Enable test_imapUrls for imap-js. r=mkmelin,benc

Comment 44

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Enable test_imapStatusCloseDBs for imap-js. r=mkmelin,benc

Implement nsIMsgProtocolInfo in ImapProtocolInfo.jsm.

Comment 45

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9dcf7c9f755e
Enable test_imapUrls for imap-js. r=mkmelin
https://hg.mozilla.org/comm-central/rev/275ff1829514
Enable test_imapStatusCloseDBs for imap-js. r=mkmelin

Comment 46

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 follow-up - Fix eslint error. r=#thunderbird-reviewers

Comment 47

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Enable test_listClosesDB and test_listSubscribed for imap-js. r=mkmelin,benc

Comment 48

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fab0ee26c820
follow-up - Fix eslint error. r=#thunderbird-reviewers,john.bieling

Comment 49

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Enable test_nsIMsgFolderListenerIMAP.js for imap-js. r=mkmelin,benc

Comment 50

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6533be800ca3
Enable test_listClosesDB and test_listSubscribed for imap-js. r=mkmelin

Comment 51

[Magnus Melin [:mkmelin]]

There appears to be some test failures on debug for comm/mailnews/imap/test/unit/test_listClosesDB.js, I'd assume from the above

Comment 52

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5e4f25b6580b
Backed out changeset 6533be800ca3 for test failures on debug. rs=backout

Comment 53

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/55db54fcb9a6
Enable test_listClosesDB and test_listSubscribed for imap-js. r=mkmelin
https://hg.mozilla.org/comm-central/rev/ba240081a2ec
Enable test_nsIMsgFolderListenerIMAP.js for imap-js. r=mkmelin

Comment 54

[Magnus Melin [:mkmelin]]

comm/mailnews/imap/test/unit/test_offlineCopy.js is failing

Comment 55

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Disable test_offlineCopy for imap-js. r=#thunderbird-reviewers

Comment 56

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5038702cfea3
Disable test_offlineCopy for imap-js. r=mkmelin

Comment 57

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Make nsImapOfflineSync usable in JS. r=mkmelin,benc

Comment 58

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Enable test_offlineDraftDataloss.js for imap-js. r=mkmelin,benc

Implement playbackAllOfflineOperations in ImapService.jsm.

Comment 59

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/23d6b9b8e1e7
Make nsImapOfflineSync usable in JS. r=mkmelin,benc
https://hg.mozilla.org/comm-central/rev/7d40610a7778
Enable test_offlineDraftDataloss.js for imap-js. r=benc

Comment 60

[Magnus Melin [:mkmelin]]

23d6b9b8e1e7 introduced some code in-consistencies caught by coverity. Will attach patches.

Comment 61

[Magnus Melin [:mkmelin]]

Attachment: Bug 1762688 - [coverity] Fix m_createdOfflineFolders is not initialized. r=benc

CID 1516449: Uninitialized members (UNINIT_CTOR)
Non-static class member "m_createdOfflineFolders" is not initialized in this constructor nor in any functions that it calls.

Comment 62

[Magnus Melin [:mkmelin]]

Attachment: Bug 1762688 - [coverity] goOnline is never null. r=benc

CID 1516448: Null pointer dereferences (REVERSE_INULL)
Null-checking "goOnline" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.

Comment 63

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Enable test_imapUndo for imap-js. r=mkmelin,benc

Comment 64

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/43d17317a265
[coverity] Fix m_createdOfflineFolders is not initialized. r=benc
https://hg.mozilla.org/comm-central/rev/e2be49a591d4
[coverity] goOnline is never null. r=benc
https://hg.mozilla.org/comm-central/rev/a96cfcef15d4
Enable test_imapUndo for imap-js. r=mkmelin

Comment 65

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Fix rendering of attachments in imap-js. r=mkmelin,benc

Comment 66

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/076a3e0de254
Fix rendering of attachments in imap-js. r=mkmelin

Comment 67

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Improve handling of IDLE command in imap-js. r=mkmelin,benc

• Allow IDLE command for multiple folders in a server
• Try to reuse non-inbox IDLE connection first

Comment 68

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Support using memory cache in imap-js. r=mkmelin,benc

Comment 69

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/841aa2861a88
Support using memory cache in imap-js. r=mkmelin
https://hg.mozilla.org/comm-central/rev/0713e048b56c
Improve handling of IDLE command in imap-js. r=mkmelin

Comment 70

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Implement nsIImapService.getBodyStart to fix mail notification. r=mkmelin,benc

Comment 71

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b584fc92ec01
Implement nsIImapService.getBodyStart to fix mail notification. r=mkmelin

Comment 72

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Implement ImapService.deleteFolder. r=mkmelin,benc

Comment 73

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/58741b136cd3
Implement ImapService.deleteFolder. r=mkmelin

Comment 74

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Fixes for extension tests to pass in imap-js. r=mkmelin,benc

Comment 75

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0f118321b9eb
Fixes for extension tests to pass in imap-js. r=mkmelin

Comment 76

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Fix for gloda tests to pass in imap-js. r=mkmelin,benc

Comment 77

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Implement ImapService.deleteAllMessages and ImapMessageService.search. r=mkmelin,benc

Comment 78

[Ping Chen [:rnons] (away)]

Attachment: Bug 1762688 - Enable imap-js in nightly build. r=mkmelin,sancus

Comment 79

[Wayne Mery (:wsmwk)]

From team meeting notes, current plan is to enable IMAP JS in May.

Comment 80

[Wayne Mery (:wsmwk)]

Also, before mailnews.imap.jsmodule is set true on daily, I suggest enlisting interested testers to test it (including team members who run nightly) by publicizing to Daily topicbox and perhaps other venues. A month or two in advance? (or whenever it is deemed good enough for testing)

https://wiki.mozilla.org/MailNews:Logging has been updated to include the new imap logging preference

Comment 81

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cb4a2a12218e
Fix for gloda tests to pass in imap-js. r=mkmelin
https://hg.mozilla.org/comm-central/rev/1c6c7fc3abfb
Implement ImapService.deleteAllMessages and ImapMessageService.search. r=mkmelin

Comment 82

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2eb2ae16e3e9
Enable imap-js in nightly build. r=mkmelin,sancus

Comment 83

[Alessandro Castellani [:aleca]]

Out of curiosity, why do we have the pref also defined in mailnews.js? https://searchfox.org/comm-central/rev/db81589f13e9d7b1d47c2a466d19b15715dcf277/mailnews/mailnews.js#339

Comment 84

[Ping Chen [:rnons] (away)]

My understanding is mailnews.js contains default values for c-c, all-thunderbird.js contains default values for tb.

Better to set regressed by to bug 1707547, thanks.