1762861 - gfx/thebes/gfxDWriteFonts.cpp fails clang thread safety analysis on Windows

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

When building on Windows with thread safety analysis enabled and warnings as errors I get the following:

 0:11.59 C:/projects/mozilla/mozilla-unified/gfx/thebes/gfxDWriteFonts.cpp(285,40): error: reading variable 'mUnscaledFont' requires holding mutex 'mLock' [-Werror,-Wthread-safety-analysis]
 0:11.59       static_cast<UnscaledFontDWrite*>(mUnscaledFont.get());
 0:11.59                                        ^
 0:11.80 1 error generated.

Comment 1

[Jonathan Kew [:jfkthame]]

Thanks, I'll look into this. (I think this may be a case where the annotations I added are too strict, and we don't actually need to take the lock here. Checking....)

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1762861 - Remove GUARDED_BY annotation from gfxFont::mUnscaledFont, as it is inert once constructed so locking is not required. r=lsalzman

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1bee69377090
Make gfxFont::mUnscaledFont const and remove GUARDED_BY annotation, as it is inert once constructed. r=lsalzman

Comment 4

[Marian-Vasile Laza]

Backed out changeset 1bee69377090 (Bug 1762861) for causing bustages on gfxGDIFont.obj.
Backout link
Push with failures
Failure Log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e660dce5e760
Remove GUARDED_BY annotation from gfxFont::mUnscaledFont, as it is inert once constructed so locking is not required. r=lsalzman

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/e660dce5e760