make sure to draw swipe to nav ui element opaque if velocity pushes us over success threshold
Categories
(Core :: Panning and Zooming, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox102 | --- | fixed |
People
(Reporter: tnikkel, Assigned: tnikkel)
References
Details
Attachments
(2 files)
|
Assignee | |
Comment 1•2 years ago
|
||
Both the velocity and displacement contribute to the success but we only pass the displacement in the swipe events which browser-gestureSupport.js uses to draw the opacity of the ui element. Usually that is what we want, but if the velocity is large we might draw the ui element only very faintly but still navigate the page. We should make sure to draw the ui element so it's well visible.
Depends on D142818
|
||
Updated•2 years ago
|
|
|
Assignee | |
Comment 2•2 years ago
|
||
|
||
Comment 3•2 years ago
|
||
There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:tnikkel, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.
|
|
Assignee | |
Comment 4•2 years ago
|
||
Writing tests/waiting for soft freeze.
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d6975c4a6b6f Make sure to draw swipe to nav ui element opaque if velocity pushes us over success threshold. r=hiro https://hg.mozilla.org/integration/autoland/rev/25b10e322d4b Add test. r=hiro
|
||
Comment 6•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d6975c4a6b6f
https://hg.mozilla.org/mozilla-central/rev/25b10e322d4b
Description
•