Closed Bug 1762881 Opened 3 years ago Closed 3 years ago

swipe to nav _completeFadeOut isn't called, potentially putting us in an inconsistent state

Categories

(Core :: Panning and Zooming, defect, P2)

Product:
Core
Component:
Panning and Zooming
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
102 Branch
Tracking Flags:
Tracking Status
firefox102 --- fixed

People

(Reporter: tnikkel, Assigned: tnikkel)

References

Details

Attachments

(2 files)

Bug 1762881. Make sure swipe to nav _completeFadeOut is called. r?hiro
48 bytes, text/x-phabricator-request
Details | Review
Bug 1762881. Add test. r?hiro
48 bytes, text/x-phabricator-request
Details | Review
No description provided.
Summary: swipe to _completeFadeOut isn't called, potentially putting us in an inconsistent state → swipe to nav _completeFadeOut isn't called, potentially putting us in an inconsistent state

I think this is because this._completeFadeOut is a function but calling it from to handle the event isn't going to have any reference to this so it doesn't do anything.

Depends on D142820

Assignee: nobody → tnikkel
Status: NEW → ASSIGNED

The severity field is not set for this bug.
:botond, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(botond)
Severity: -- → S3
Flags: needinfo?(botond)
Priority: -- → P2
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3a6461d743a6 Make sure swipe to nav _completeFadeOut is called. r=hiro https://hg.mozilla.org/integration/autoland/rev/ad2ba160bc66 Add test. r=hiro

https://hg.mozilla.org/mozilla-central/rev/3a6461d743a6
https://hg.mozilla.org/mozilla-central/rev/ad2ba160bc66

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox102: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: