Closed Bug 1762942 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33494 - Convert <embed hidden> into a proper boolean attribute

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
101 Branch
Tracking Flags:
Tracking Status
firefox101 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33494 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33494
Details from upstream follow.

Mason Freed <masonf@chromium.org> wrote:

Convert <embed hidden> into a proper boolean attribute

Prior to this CL, \<embed hidden> would still be visible. Only the
special values of \<embed hidden=yes> or \<embed hidden=true> would
"hide" the \<embed>. (And it would be "hidden" by making it zero-
size, presumably to not change loading behavior.)

After this CL, the 'hidden' attribute behaves as a normal
boolean attribute - presence of the attribute is interpreted as
a "true" value.

This appears to be per-spec:
https://html.spec.whatwg.org/#the-embed-element
https://html.spec.whatwg.org/#the-hidden-attribute
https://html.spec.whatwg.org/#boolean-attribute

Gecko does not respect the 'hidden' attribute at all on the \<embed>
element. WebKit behavior matches the new behavior here - it
treats 'hidden' as a regular boolean attribute, honoring it if present.
Because the spec matches this new behavior, and because WebKit already
agrees with the behavior, I'm treating this like a bug fix, and not
something that needs an I2S. It seems like quite a corner case for a
site to be using \<embed hidden=dont> or something, and expecting the
embed not to be hidden.

Fixed: 1063756
Change-Id: I1fc11d0de6ff9e3cc2f7c0d3e438ab9fc929e36b

Reviewed-on: https://chromium-review.googlesource.com/3565492
WPT-Export-Revision: d41b82205761d5209c82b45d85375fb984abc9fd

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/semantics/embedded-content/the-embed-element/embed-hidden-attribute.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/514c6ce06e8f
[wpt PR 33494] - Convert <embed hidden> into a proper boolean attribute, a=testonly
https://hg.mozilla.org/integration/autoland/rev/01142f5edb61
[wpt PR 33494] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/514c6ce06e8f
https://hg.mozilla.org/mozilla-central/rev/01142f5edb61

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox101: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
You need to log in before you can comment on or make changes to this bug.