1762947 - Don't skip validation of branches that use variables only features.

Status: RESOLVED FIXED

(Firefox :: Nimbus Desktop Client, defect, P1)

Description

[Beth Rennie [:beth] (she/her)]

Bug 1761105 started validation of features with variables listed (not just schemas), but we erroneously skip validation of the first branch because of this continue statement

Comment 1

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1762947 - Validate all branches when using variables-only features r?emcminn

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b11b00d98c2
Validate all branches when using variables-only features r=emcminn

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/8b11b00d98c2

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1761105

Comment 5

[Beth Rennie [:beth] (she/her)]

Comment on attachment 9270744 [details]
Bug 1762947 - Validate all branches when using variables-only features r?emcminn

Beta/Release Uplift Approval Request

• User impact if declined: It is possible that we would accept an experiment that would fail validation.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It is unlikely that we would hit this issue in reality due to the experiment schema being checked on experimenter's end before its sent to the client.
• String changes made/needed:

Comment 6

[Dianna Smith [:diannaS]]

Comment on attachment 9270744 [details]
Bug 1762947 - Validate all branches when using variables-only features r?emcminn

Approved for 100.0b3

Comment 7

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4b4334f37b62