Closed Bug 1762991 Opened 2 years ago Closed 2 years ago

Add a --disable-fission option to mach xpcshell-test

Categories

(Testing :: XPCShell Harness, task, P3)

Product:
Testing
Component:
XPCShell Harness
Version:
Default
Type:
task

Tracking

(firefox102 fixed)

Status:
RESOLVED FIXED
Milestone:
102 Branch
Tracking Flags:
Tracking Status
firefox102 --- fixed

People

(Reporter: mccr8, Assigned: jmaher)

References

Details

Attachments

(2 files)

Bug 1762991 - switch to --disable-fission and fission by default. r=gbrown!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1762991 - fix raptor/btime to have the fission attribute. r=sparky!
48 bytes, text/x-phabricator-request
Details | Review

It would be nice if there was a way to disable Fission when running XPCShell tests via mach.

Right now, you have to do it with --setpref fission.autostart=false which is a little awkward.

well right now we don't run with fission enabled, but overall I think we should add this in. We will only be running xpcshell tests without fission on linux- would you prefer that we make this available on all platforms?

(In reply to Joel Maher ( :jmaher ) (UTC -0800) from comment #1)

well right now we don't run with fission enabled, but overall I think we should add this in. We will only be running xpcshell tests without fission on linux- would you prefer that we make this available on all platforms?

mach xpcshell-test runs with Fission enabled, as far as I can tell. Which is a little confusing given that we run without Fission in automation. I don't know how useful this will really be, but yeah, it should be on all platforms. Really, it is just a bit of convenience and consistency.

when I get to cleaning up fission by default, then making --no-fission or --disable-fission will be the mode everywhere; I will keep this on my list for when I land the xpcshell w/fission changes (bug 1751492)

Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/60dcc095f627
switch to --disable-fission and fission by default. r=gbrown,webdriver-reviewers,whimboo
Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Backed out for causing multiple failures (exit status 2)

Flags: needinfo?(jmaher)

thanks, I overlooked android hardware tests, fixed the patch and it is up for review.

Flags: needinfo?(jmaher)
Backout by csabou@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/88cc762972b1
Backed out changeset 60dcc095f627 for causing multiple failures (exit status 2). CLOSED TREE
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1ce55e10b927
switch to --disable-fission and fission by default. r=gbrown,webdriver-reviewers,whimboo

thanks; I see I overlooked an edge case on desktop- a couple extra try pushes and my patch looks good for another try

Flags: needinfo?(jmaher)
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dfcdb4347811
switch to --disable-fission and fission by default. r=gbrown,webdriver-reviewers,whimboo

https://hg.mozilla.org/mozilla-central/rev/dfcdb4347811

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox102: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
Regressions: 1768964

Is it possible this broke some of the benchmarks on AWFY? For example this hasn't been updating the past days: https://arewefastyet.com/win10/benchmarks/raptor-desktop-matrix-react-bench?numDays=60

Flags: needinfo?(jmaher)

this is a good question, I see tests still running on mozilla-central every commit:
https://treeherder.mozilla.org/jobs?repo=mozilla-central&tier=1%2C2%2C3&searchStr=matrix-react%2Cwin&fromchange=70a9f214d8d3a5e97b928d2a650a823ba368dea2

the task name hasn't changed at all, but the metadata for the replicates lost the fission tag. I will look into this, it does seem like a regression from this patch.

Flags: needinfo?(jmaher)

How can we run fission geckoview-junit tests after this change? Using --setpref fission.autostart=true doesn't work and the test defaults to non-fission mode.

Flags: needinfo?(jmaher)

:agi, thanks for catching this. I assume you mean via ./mach. in CI we run geckoview-junit-fis successfully. I think the area of code to fix is:
https://hg.mozilla.org/mozilla-central/rev/dfcdb4347811#l16.2

I suspect there is a simple fix for it. On my short list to look at today.

Flags: needinfo?(jmaher)

Yeah I meant locally, I verified in CI that we do the right thing and enable fission for fis jobs. Thanks.

Pushed by bszekely@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/c4ce96e5fe0a
fix raptor/btime to have the fission attribute. r=sparky,perftest-reviewers

:jandem, benchmark data is now back- sorry for the ~2 day interruption.

:agi, your issue with junit is still high on my list.

Regressions: 1769503

(In reply to Joel Maher ( :jmaher ) (UTC -0800) from comment #23)

:jandem, benchmark data is now back- sorry for the ~2 day interruption.

Thank you! \o/

Regressions: 1769544
No longer regressions: 1769544
Regressions: 1769794
Regressions: 1771485
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/34398 for changes under testing/web-platform/tests
Upstream PR was closed without merging

(In reply to Web Platform Test Sync Bot (Matrix: #interop:mozilla.org) from comment #25)

Created web-platform-tests PR
https://github.com/web-platform-tests/wpt/pull/34398 for changes under
testing/web-platform/tests

This change never got merged upstream! There is https://github.com/web-platform-tests/wpt/pull/42386 now to fix that.

(In reply to Henrik Skupin [:whimboo][⌚️UTC+2] from comment #27)

This change never got merged upstream! There is https://github.com/web-platform-tests/wpt/pull/42386 now to fix that.

And it got merged 3 days ago.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: