176307 - layout string cleanup

Status: NEW

(Core :: Layout, defect, P3)

Description

[Alec Flett]

So the other day I poked at two things:
1) printing was passing around a lot of PRUnichar*'s where they should have been
using const PRUnichar* - this resulted in a slightly cleaner API with slightly
less casting
2) layout uses a unicode string to represent the content type (i.e. "text/html")
of a document, and that just seemed wasteful. So I changed it to use ASCII...
this resulted in a few less conversions as necko stores the content type as
ASCII already.

I cleaned up a few random other things as well, figured I'd roll all the changes
into one patch (including fixing a few "new nsString", use of nsString when
nsAutoString would be better, etc. Don't ask how I found this stuff.

I'd like to get an r=jkeiser, sr=jag or sr=dbaron.

Comment 1

[Alec Flett]

Attachment: clean up some string usage

Here's the patch. Its not small, but it is really straight forward.

Comment 2

[jag (Peter Annema)]

Comment on attachment 103897 [details] [diff] [review]
clean up some string usage

Bug me sometime in 1.3 for review. Are all these changes from support for
unicode to just ascii safe?

Comment 3

[Alec Flett]

moving somewhat important bugs to 1.3beta for consideration - some of these may
be bumped out to 1.4alpha after being evaluated.

Comment 4

[Michael Buckland]

Discussed in edt bug triage.  Plussing.

Comment 5

[Alec Flett]

bumping these to 1.5alpha, I just don't have time in 1.4beta...

Comment 6

[mmc]

Has the time come to get the patch in this bug reviewed?

Comment 7

[Eli Friedman]

Hmm, looks like changing nsIDocumentEncoder to take an ACString for mime types might still be worth doing.  The rest is mostly obsolete.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information