1763093 - Crash in [@ OOM | unknown | SwitchToFiber]

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Calixte Denizet (:calixte)]

Maybe Fission related. (DOMFissionEnabled=1)

Crash report: https://crash-stats.mozilla.org/report/index/eaefa881-0fa4-4864-bfc1-7dadc0220403

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 8 frames of crashing thread:

0 kernelbase.dll SwitchToFiber 
1 xul.dll RunOnTemporaryStack toolkit/crashreporter/breakpad-client/windows/crash_generation/temporary_stack.cc:73
2 ntdll.dll RtlpTpWaitCallback 
3 ntdll.dll TppExecuteWaitCallback 
4 ntdll.dll TppWorkerThread 
5 kernel32.dll BaseThreadInitThunk 
6 mozglue.dll patched_BaseThreadInitThunk toolkit/xre/dllservices/mozglue/WindowsDllBlocklist.cpp:572
7 ntdll.dll RtlUserThreadStart 

There are 4 crashes (from 4 installations) in nightly 100 starting with buildid 20220403090644. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1758654.

[1] https://hg.mozilla.org/mozilla-central/rev?node=a07bb9e2ffe8

Comment 1

[Gabriele Svelto [:gsvelto]]

The machines in the crashes have very little memory available, no wonder that our large allocation cause them to fail. Raymond do you think it would be possible to soft-fail here, running without the fiber if there isn't enough memory available?

Comment 2

[Ray Kraesig [:rkraesig]]

Yes. (Under the circumstances, I expect we'll still crash; but it's only likely, not certain.)

Working on a patch now.

Comment 3

[Ray Kraesig [:rkraesig]]

Attachment: Bug 1763093 - fall back to running on the existing thread r?gsvelto

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00021097701b
fall back to running on the existing thread  r=gsvelto

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/00021097701b

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:rkraesig, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Ray Kraesig [:rkraesig]]

(In reply to Release mgmt bot [:suhaib / :marco/ :calixte] from comment #7)

:rkraesig, is this bug important enough to require an uplift?

No, but it's important enough to require a rollback of the original patch.