1763243 - Investigate the best way to avoid extraneous line breaks in auto-generated subtitles on Youtube

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect)

Description

[Niklas Baumgardner [:niklas]]

In auto-generated Youtube subtitles, PiP creates extraneous line breaks, worsening subtitles readability. This occurs because we respect both the line breaks received from YouTube and line breaks occurring when max-width of the subtitles container is reached.

As discussed, some possible approaches could be:
detecting auto-generated subs and forcing Youtube’s caption container width to PiP max-width or detecting auto-generated subs and ignoring line breaks.

Comment 1

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1763243 - Increase text-track width on PiP windows. r=#pip-reviewers!

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mconley, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/edfc7bfc1175
Increase text-track width on PiP windows. r=pip-reviewers,desktop-theme-reviewers,kpatenio

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/edfc7bfc1175

Comment 5

[Daniel Bodea [:danibodea]]

I have verified this fix in Nightly v102.0a1 and Beta v101.0 (RC) and confirmed that the original issue is still reproducing in older branches.