Open Bug 1763270 Opened 3 years ago Updated 3 years ago

[Automated review] reviewbot code-coverage defect report provides no information

Categories

(Conduit :: Phabricator, defect)

defect

Tracking

(Not tracked)

People

(Reporter: rkraesig, Unassigned)

Details

Phabricator URL: https://phabricator.services.mozilla.com/D143000#4674666

reviewbot reports "3 defects found by code coverage analysis" and "we found some files which had no coverage and are being modified in this patch", but does not specify which files those are. The links at the bottom of that comment go to pages that indicate no errors or warnings.

(Possibly a duplicate of bug 1762034 or bug 1745327; but those seem to be specific to other classes of defect-reporting...?)

Addendum: there are now "Lint: code coverage analysis" blocks reading "WARNING: This file is uncovered".

I should mention that I did read several other bugs like this before writing this bug, and I was forewarned about the possibility of these. Before hitting Submit, I specifically looked for them or anything like them, and did not see them.

It is still possible that I could have missed them — I have missed more obvious things, in the past — but I honestly think it more likely that they simply weren't there at the time.

The bot is always both reporting a comment and the Phabricator lint issues. It is reporting the lint issues first and the comment later, so there is no moment in which the comment is published and the lint issues aren't yet.
If we are seeing the lint issues now (https://phabricator.services.mozilla.com/D143000?id=564751), they must have been there even at the time you saw the comment and maybe you somehow missed them.

If they actually weren't there, then it is a bug in Phabricator.

Component: Source Code Analysis → Phabricator
Product: Firefox Build System → Conduit
You need to log in before you can comment on or make changes to this bug.