1763328 - Use semver requirement in geckodriver's Cargo.toml for internal dependencies

Status: RESOLVED FIXED

(Testing :: geckodriver, task, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

With bug 1579902 the mozrunner's Cargo.toml has been updated to require a specific version of mozprofile. During the review of the geckodriver 0.31.0 related version bumps we noticed that this might not be needed anymore.

Lets check after the 0.31.0 release if this can be removed.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

James, I wonder if that combination might actually be useful for cargo publish. If we would provide both the path and version for the mozrunner, marionette and geckodriver crates maybe changing these lines (to replace the path with version) would not be necessary?

Comment 2

[James Graham [:jgraham]]

https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#multiple-locations does seem to support that usage.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As discussed we should actually use the same logic in geckodriver's Cargo.toml which is the only one where we have to get this added for all the internal dependencies that have a path only right now:

https://searchfox.org/mozilla-central/source/testing/geckodriver/Cargo.toml

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We should actually include the required changes here into the updates for the release documentation.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit auto_nag documentation.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1763328 - [geckodriver] Use semver beside path for internal crate dependencies.

Depends on D143380

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a544e00ff424
[geckodriver] Use semver beside path for internal crate dependencies. r=webdriver-reviewers,jgraham

Comment 8

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/a544e00ff424