Closed Bug 1763328 Opened 10 months ago Closed 10 months ago

Use semver requirement in geckodriver's Cargo.toml for internal dependencies

Categories

(Testing :: geckodriver, task, P2)

Default
task
Points:
1

Tracking

(firefox101 fixed)

RESOLVED FIXED
101 Branch
Tracking Status
firefox101 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Whiteboard: [bidi-m3-mvp])

Attachments

(1 file)

With bug 1579902 the mozrunner's Cargo.toml has been updated to require a specific version of mozprofile. During the review of the geckodriver 0.31.0 related version bumps we noticed that this might not be needed anymore.

Lets check after the 0.31.0 release if this can be removed.

James, I wonder if that combination might actually be useful for cargo publish. If we would provide both the path and version for the mozrunner, marionette and geckodriver crates maybe changing these lines (to replace the path with version) would not be necessary?

Flags: needinfo?(james)
Priority: -- → P3

As discussed we should actually use the same logic in geckodriver's Cargo.toml which is the only one where we have to get this added for all the internal dependencies that have a path only right now:

https://searchfox.org/mozilla-central/source/testing/geckodriver/Cargo.toml

Component: Mozbase Rust → geckodriver
Summary: [mozrunner] Consider removing the mozprofile's semver requirement from Cargo.toml → Use semver requirement in geckodriver's Cargo.toml for internal dependencies

We should actually include the required changes here into the updates for the release documentation.

Blocks: 1731062

The component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit auto_nag documentation.

Priority: P3 → --
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a544e00ff424
[geckodriver] Use semver beside path for internal crate dependencies. r=webdriver-reviewers,jgraham
Points: --- → 1
Priority: -- → P2
Whiteboard: [bidi-m3-mvp]
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
You need to log in before you can comment on or make changes to this bug.