1763364 - Remove RootActor#getTab/BrowserTabList.getTab obsolete options

Status: RESOLVED FIXED

(DevTools :: Framework, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

Since Bug 1755963, the codebase migrated most callsites to pass a browserId to getTab.
Now that Firefox 99 is in release, the 2 other options, outerWindowID and tabId can be removed.
The only downside would be that we can break 3rd party tools using those, but I'd argue that if we did migrate to browserId to fix an issue, they should too.

Comment 1

[Stefan Popa]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #0)

Since Bug 1755963, the codebase migrated most callsites to pass a browserId to getTab.
Now that Firefox 99 is in release, the 2 other options, outerWindowID and tabId can be removed.
The only downside would be that we can break 3rd party tools using those, but I'd argue that if we did migrate to browserId to fix an issue, they should too.

Attach a log file please!!

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1763364 - [devtools] Call getTab with browserId instead of outerWindowID. r=ochameau.

This allows to remove the outerWindowID option from getTab.

Depends on D143026

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1763364 - [devtools] Remove getTab unused option tabId. r=ochameau.

Depends on D143027

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Stefan Popa from comment #1)

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #0)

Since Bug 1755963, the codebase migrated most callsites to pass a browserId to getTab.
Now that Firefox 99 is in release, the 2 other options, outerWindowID and tabId can be removed.
The only downside would be that we can break 3rd party tools using those, but I'd argue that if we did migrate to browserId to fix an issue, they should too.

Attach a log file please!!

I'm not sure what you mean

Comment 5

[Stefan Popa]

I'm not sure what you mean

A log file is a text file with reports for detail

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Stefan Popa from comment #5)

I'm not sure what you mean

A log file is a text file with reports for detail

details are already in the summary of the bug. Please stop spamming bugzilla with meaningless comments

Comment 7

[Stefan Popa]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #6)

(In reply to Stefan Popa from comment #5)

I'm not sure what you mean

A log file is a text file with reports for detail

details are already in the summary of the bug. Please stop spamming bugzilla with meaningless comments

OK! I stop spamming BugZilla with meaningless comments

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc3ef78f1291
[devtools] Call getTab with browserId instead of outerWindowID. r=ochameau,devtools-backward-compat-reviewers,bomsy.
https://hg.mozilla.org/integration/autoland/rev/e680e874ca0d
[devtools] Remove getTab unused option tabId. r=ochameau,devtools-backward-compat-reviewers,bomsy.

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/fc3ef78f1291
https://hg.mozilla.org/mozilla-central/rev/e680e874ca0d