176337 - ctrl-enter www.*.com in location bar can not be undone

Status: RESOLVED WORKSFORME

(Firefox :: Address Bar, defect)

Description

[Tuukka Tolvanen (sp3000)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2b) Gecko/20021023 Phoenix/0.3
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2b) Gecko/20021023 Phoenix/0.3

.

Reproducible: Always

Steps to Reproduce:
 1. Press (ctrl|shift|ctrl+shift)-Enter instead of alt-Enter in URL Bar
 2. roar
 3. Press ctrl-z

Actual Results:  
Nothing.

Expected Results:  
Undo the horrible mistake an apologize profusely, preferably with a cup of
coffee and a bagel.

Comment 1

[David Tenser [:djst]]

I'm confirming this, but in fact, the address field doesn't seem to save the
undo for non-autocomleted url:s either, at least not if it's processed.

As soon as you enter a new site, the old entry is gone and the Undo is wiped. So
if this really is to be considered a bug, it also applies on a normal Enter
keypress.

Comment 2

[Tuukka Tolvanen (sp3000)]

re comment 1:

 a) The address field _does not_ allow undo after <enter> if the url loads ok.
 b) The address field _does not_ allow undo after
    <tld-adding-modifiers>+<enter> if the url loads ok.
 c) The address field _does_ allow undo after <enter> if the url fails to
    resolve.
 d) The address field _does not_ allow undo after
    <tld-adding-modifiers>+<enter> if the url fails to resolve.

(a), (b) could be considered bugs, but those are imo quite irrelevant. (c) is
only more useful than <esc> if you first type an unresolving address, then
another, and then want to get back to the first unresolved address --
unlikely.

This bug is (d), where the undo command should give you back your unmangled
url, if the mangling was accidental or otherwise did not help you get where
you wanted to go -- which is most obvious when the address doesn't resolve.
For example:
  * You wanted to go to www.asdf.org but hit <shift>+<enter> and failed to
    resolve www.asdf.net -- you need to manually remove the mangling before
    hitting <ctrl>+<shift>+<enter>.
  * You wanted to open a complete url you typed in a new tab, but used the
    wrong (mozilla nav, <ctrl>) modifier -- you need to manually remove the
    mangling before hitting <alt>+<enter>.

Bumping back to minor

Comment 3

[David Tenser [:djst]]

I really think this should be a WONTFIX. How often do you use Undo in the
address field? I've never used it ever, neither in IE nor Mozilla/Phoenix.

Comment 4

[Asa Dotzler [:asa]]

hyatt said this should work but he's not likely to get to it any time soon
(probably not before 1.0)

Comment 5

[Jesse Ruderman]

This is a bug, but since the address bar loses focus when you hit ctrl+enter
(bug 90919), fixing it won't let you Undo immediately.

Comment 6

[Jesse Ruderman]

See also bug 187850, ctrl+enter in address bar tries to go to URLs like
http://www.http://mozilla.org/.com/ .

Comment 7

[Felipe Hoffa]

I wouldn't need this if bug 177498 didn't exist, but this is the most common
error I have while using phoenix. This feature would ease the frustration I find
each time I press ctrl-enter instead of alt-enter.

Comment 8

[Simon Paquet [:sipaq]]

Taking QA Contact

Comment 9

[Dominic]

I think this has been fixed.

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

I cannot reproduce this issue, however focus *is* taken away from the address bar.

My steps to test this:
1. Set focus on the address bar
2. Type jaredwein
3. Hit ctrl+enter
4. Notice that the site (http://www.jaredwein.com) cannot be loaded
5. Put focus on the address bar
6. Press ctrl+z to undo
7. Notice that the address has been changed back to jaredwein