Fix browser_webconsole_scroll failures with virtualization
Categories
(DevTools :: Console, task)
Tracking
(firefox101 fixed)
| Tracking | Status | |
|---|---|---|
| firefox101 | --- | fixed |
People
(Reporter: alexical, Assigned: alexical)
References
Details
Attachments
(1 file)
With bug 1753177, the browser_webconsole_scroll test intermittently fails. Extensive manual testing of scroll behavior suggests that this is not a serious problem which will hurt users' experience. However, we need to sort out the underlying cause and resolve it.
|
Assignee | |
Comment 1•2 years ago
|
||
Eugh - my attempts to validate that every SmartTrace had been expanded were
just hackish and incorrect. What appears to have been happening was a race
between the Promise.race in SmartTrace.js and the IntersectionObserver callback
after setting the output's scrollTop to 0 in the test. If the Promise.race is
fast enough, it executes right after the test yields execution after setting
scrollTop, causing it to run before the IntersectionObserver callback is able
to disable scroll pinning. Setting the default initialRenderDelay to 1 instead
of 100 is enough to get this to happen reliably for me.
I don't think we need any changes other than the change to this test, because I
don't expect this to be a problem that really shows up in practice, and it
would be easily remedied by the user simply continuing to scroll.
|
||
Updated•2 years ago
|
Pushed by dothayer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c45617aab468 Fix browser_webconsole_scroll with virtualization r=nchevobbe
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Description
•