1763466 - System.err: java.lang.SecurityException: Isolated process not allowed to call getContentProvider

Status: RESOLVED FIXED

(GeckoView :: Sandboxing, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Via bug 1762428 we tried to enable print to pdf tests for WebDriver. But we see perma failures for all of these tests due to the following crash:

https://treeherder.mozilla.org/logviewer?job_id=373628409&repo=autoland&lineNumber=77126

https://firefoxci.taskcluster-artifacts.net/KDNjITJ-SaOjZt00xg6V6A/0/public/test_info/logcat-emulator-5554.log

04-06 17:13:58.097 16681 16695 I Gecko   : [Child 16681, Main Thread] WARNING: NS_ENSURE_TRUE(rootView) failed: file /builds/worker/checkouts/gecko/layout/base/nsPresContext.cpp:1060
04-06 17:13:58.102 16681 16695 W System.err: java.lang.SecurityException: Isolated process not allowed to call getContentProvider
04-06 17:13:58.102 16681 16695 W System.err: 	at android.os.Parcel.readException(Parcel.java:1683)
04-06 17:13:58.102 16681 16695 W System.err: 	at android.os.Parcel.readException(Parcel.java:1636)
04-06 17:13:58.102 16681 16695 W System.err: 	at android.app.ActivityManagerProxy.getContentProvider(ActivityManagerNative.java:4169)
04-06 17:13:58.102 16681 16695 W System.err: 	at android.app.ActivityThread.acquireProvider(ActivityThread.java:5434)
04-06 17:13:58.102 16681 16695 W System.err: 	at android.app.ContextImpl$ApplicationContentResolver.acquireProvider(ContextImpl.java:2248)
04-06 17:13:58.102 16681 16695 W System.err: 	at android.content.ContentResolver.acquireProvider(ContentResolver.java:1499)
04-06 17:13:58.102 16681 16695 W System.err: 	at android.provider.Settings$NameValueCache.lazyGetProvider(Settings.java:1554)
04-06 17:13:58.102 16681 16695 W System.err: 	at android.provider.Settings$NameValueCache.getStringForUser(Settings.java:1597)
04-06 17:13:58.102 16681 16695 W System.err: 	at android.provider.Settings$System.getStringForUser(Settings.java:1911)
04-06 17:13:58.102 16681 16695 W System.err: 	at android.text.format.DateFormat.is24HourFormat(DateFormat.java:180)
04-06 17:13:58.102 16681 16695 W System.err: 	at android.text.format.DateFormat.is24HourFormat(DateFormat.java:168)
04-06 17:13:58.102 16681 16695 W System.err: 	at org.mozilla.gecko.GeckoAppShell.getIs24HourFormat(GeckoAppShell.java:1508)
04-06 17:13:58.102 16681 16695 W System.err: 	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
04-06 17:13:58.102 16681 16695 W System.err: 	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:677)
04-06 17:13:58.103 16714 16738 D EGL_emulation: eglMakeCurrent: 0x7d7b7a3afd00: ver 3 0 (tinfo 0x7d7b7a30ac60)
04-06 17:13:58.103 16681 16695 F MOZ_CRASH: Hit MOZ_CRASH(JNI exception) at /builds/worker/workspace/obj-build/dist/include/mozilla/jni/Accessors.h:61

Comment 1

[Chris Peterson [:cpeterson]]

P2

tier 2 test for isolated process (meta bug 1565196)

Job name: test-android-em-7.0-x86_64-qr/debug-isolated-process-geckoview-web-platform-tests-wdspec-nofis-e10s-1

Comment 2

[Olivia Hall [:olivia]]

PrintToPdf calls getIs24HourFormat in GeckoAppShell from Gecko, which causes a crash in an isolated process.

For now, the PDF tests in an isolated process are turned off.

05-26 14:20:35.833 17012 17026 W System.err: java.lang.SecurityException: Isolated process not allowed to call getContentProvider
05-26 14:20:35.833 17012 17026 W System.err: 	at android.os.Parcel.readException(Parcel.java:1683)
05-26 14:20:35.833 17012 17026 W System.err: 	at android.os.Parcel.readException(Parcel.java:1636)
05-26 14:20:35.833 17012 17026 W System.err: 	at android.app.ActivityManagerProxy.getContentProvider(ActivityManagerNative.java:4169)
05-26 14:20:35.833 17012 17026 W System.err: 	at android.app.ActivityThread.acquireProvider(ActivityThread.java:5434)
05-26 14:20:35.833 17012 17026 W System.err: 	at android.app.ContextImpl$ApplicationContentResolver.acquireProvider(ContextImpl.java:2248)
05-26 14:20:35.833 17012 17026 W System.err: 	at android.content.ContentResolver.acquireProvider(ContentResolver.java:1499)
05-26 14:20:35.833 17012 17026 W System.err: 	at android.provider.Settings$NameValueCache.lazyGetProvider(Settings.java:1554)
05-26 14:20:35.833 17012 17026 W System.err: 	at android.provider.Settings$NameValueCache.getStringForUser(Settings.java:1597)
05-26 14:20:35.833 17012 17026 W System.err: 	at android.provider.Settings$System.getStringForUser(Settings.java:1911)
05-26 14:20:35.833 17012 17026 W System.err: 	at android.text.format.DateFormat.is24HourFormat(DateFormat.java:180)
05-26 14:20:35.833 17012 17026 W System.err: 	at android.text.format.DateFormat.is24HourFormat(DateFormat.java:168)
05-26 14:20:35.833 17012 17026 W System.err: 	at org.mozilla.gecko.GeckoAppShell.getIs24HourFormat(GeckoAppShell.java:1508)
05-26 14:20:35.833 17012 17026 W System.err: 	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
05-26 14:20:35.833 17012 17026 W System.err: 	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:677)

Comment 3

[Chris Peterson [:cpeterson]]

Moving isolated process bugs to the new GeckoView::Sandboxing component.

Comment 4

[Olivia Hall [:olivia]]

Attachment: Bug 1763466 - Change how is24HourFormat is determined for Isolated Process

Android's is24HourFormat could not be be called from GeckoAppShell
when using isolated process. Changed GeckoAppShell's getIs24HourFormat
to be set as a variable in GeckoRuntime, which has correct access to
is24HourFormat.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4623877be1eb
Change how is24HourFormat is determined for Isolated Process r=geckoview-reviewers,owlish

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/4623877be1eb