1763478 - Missing mozinfo flag for Android debug isolated-process builds/jobs

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Because there is no flag present in mozinfo.json files for Android debug isolated-process builds / jobs there is no way to exclude various tests from different test suites.

Here such a build:
https://treeherder.mozilla.org/jobs?repo=autoland&searchStr=android%2Cisolated&revision=ce4059195e1fa61c9f5c7ec6eef88311b0acf8a9&selectedTaskRun=QzMQHg83Q8yTS9OL6HDgjw.0

To disable the Wd1 test failures I have to disable all debug builds (see bug 1763456).

It would be great to just disable for isolated-process jobs.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox Build System::Task Configuration' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: Bug 1763478 - add isolated-process flag to mozinfo.json. r=whimboo!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf0cdfc423d3
add isolated-process flag to mozinfo.json. r=whimboo,webdriver-reviewers

Comment 4

[Cosmin Sabou [:CosminS]]

Backed out for causing wpt-metadata failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=Z35EkSY0RPmvQCAS5Gtzdg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&revision=cf0cdfc423d3d9d51cea43c68a330180700fa789

Failure log: https://treeherder.mozilla.org/logviewer?job_id=374098409&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/e302dfea54fe161056d096bb09583f1c2c1b2f0a

[task 2022-04-11T16:51:55.362Z] {"action": "log", "time": 1649695915362, "thread": "MainThread", "pid": 16, "source": "web-platform-tests", "message": "Unpacking meta/MANIFEST.json to /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_tests/web-platform/meta/MANIFEST.json", "level": "DEBUG"}
[task 2022-04-11T16:51:55.422Z] {"action": "log", "time": 1649695915421, "thread": "MainThread", "pid": 16, "source": "web-platform-tests", "message": "Unpacking mozilla/meta/MANIFEST.json to /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_tests/web-platform/mozilla/meta/MANIFEST.json", "level": "DEBUG"}
[task 2022-04-11T16:52:01.957Z] {"action": "log", "time": 1649695921957, "thread": "MainThread", "pid": 16, "source": "web-platform-tests", "message": "Loading tests linux-opt baseline", "level": "INFO"}
[task 2022-04-11T16:52:03.046Z] Traceback (most recent call last):
[task 2022-04-11T16:52:03.046Z]   File "/builds/worker/checkouts/gecko/testing/web-platform/mach_commands.py", line 386, in run
[task 2022-04-11T16:52:03.046Z]     return fissionregressions.run(logger, src_root, obj_root, **kwargs)
[task 2022-04-11T16:52:03.046Z]   File "/builds/worker/checkouts/gecko/testing/web-platform/fissionregressions.py", line 389, in run
[task 2022-04-11T16:52:03.046Z]     test_manifests, wpttest.enabled_tests, run_info, manifest_filters=[]
[task 2022-04-11T16:52:03.046Z]   File "/builds/worker/checkouts/gecko/testing/web-platform/tests/tools/wptrunner/wptrunner/testloader.py", line 253, in __init__
[task 2022-04-11T16:52:03.046Z]     self._load_tests()
[task 2022-04-11T16:52:03.047Z]   File "/builds/worker/checkouts/gecko/testing/web-platform/tests/tools/wptrunner/wptrunner/testloader.py", line 316, in _load_tests
[task 2022-04-11T16:52:03.047Z]     for test_path, test_type, test in self.iter_tests():
[task 2022-04-11T16:52:03.047Z]   File "/builds/worker/checkouts/gecko/testing/web-platform/tests/tools/wptrunner/wptrunner/testloader.py", line 307, in iter_tests
[task 2022-04-11T16:52:03.047Z]     inherit_metadata, test_metadata = self.load_metadata(manifest_file, metadata_path, test_path)
[task 2022-04-11T16:52:03.047Z]   File "/builds/worker/checkouts/gecko/testing/web-platform/tests/tools/wptrunner/wptrunner/testloader.py", line 287, in load_metadata
[task 2022-04-11T16:52:03.047Z]     metadata_path, test_path, test_manifest.url_base, self.run_info)
[task 2022-04-11T16:52:03.047Z]   File "/builds/worker/checkouts/gecko/testing/web-platform/tests/tools/wptrunner/wptrunner/manifestexpected.py", line 521, in get_manifest
[task 2022-04-11T16:52:03.047Z]     url_base=url_base)
[task 2022-04-11T16:52:03.047Z]   File "/builds/worker/checkouts/gecko/testing/web-platform/tests/tools/wptrunner/wptrunner/wptmanifest/backends/static.py", line 100, in compile
[task 2022-04-11T16:52:03.047Z]     **kwargs)
[task 2022-04-11T16:52:03.047Z]   File "/builds/worker/checkouts/gecko/testing/web-platform/tests/tools/wptrunner/wptrunner/wptmanifest/backends/static.py", line 93, in compile_ast
[task 2022-04-11T16:52:03.047Z]     **kwargs)
[task 2022-04-11T16:52:03.047Z]   File "/builds/worker/checkouts/gecko/testing/web-platform/tests/tools/wptrunner/wptrunner/wptmanifest/backends/static.py", line 29, in compile
[task 2022-04-11T16:52:03.047Z]     return self._compile(tree, data_cls_getter, **kwargs)
[task 2022-04-11T16:52:03.047Z]   File "/builds/worker/checkouts/gecko/testing/web-platform/tests/tools/wptrunner/wptrunner/wptmanifest/backends/base.py", line 33, in _compile
[task 2022-04-11T16:52:03.047Z]     self.visit(tree)
[task 2022-04-11T16:52:03.047Z]   File "/builds/worker/checkouts/gecko/testing/web-platform/tests/tools/wptrunner/wptrunner/wptmanifest/node.py", line 7, in visit
[task 2022-04-11T16:52:03.047Z]     return func(node)
[task 2022-04-11T16:52:03.047Z]   File "/builds/worker/checkouts/gecko/testing/web-platform/tests/tools/wptrunner/wptrunner/wptmanifest/backends/base.py", line 52, in visit_DataNode
[task 2022-04-11T16:52:03.047Z]     self.visit(child)
[task 2022-04-11T16:52:03.047Z]   File "/builds/worker/checkouts/gecko/testing/web-platform/tests/tools/wptrunner/wptrunner/wptmanifest/node.py", line 7, in visit
[task 2022-04-11T16:52:03.047Z]     return func(node)
[task 2022-04-11T16:52:03.047Z]   File "/builds/worker/checkouts/gecko/testing/web-platform/tests/tools/wptrunner/wptrunner/wptmanifest/backends/base.py", line 52, in visit_DataNode
[task 2022-04-11T16:52:03.047Z]     self.visit(child)
[task 2022-04-11T16:52:03.047Z]   File "/builds/worker/checkouts/gecko/testing/web-platform/tests/tools/wptrunner/wptrunner/wptmanifest/node.py", line 7, in visit
[task 2022-04-11T16:52:03.047Z]     return func(node)
[task 2022-04-11T16:52:03.047Z]   File "/builds/worker/checkouts/gecko/testing/web-platform/tests/tools/wptrunner/wptrunner/wptmanifest/backends/static.py", line 35, in visit_KeyValueNode
[task 2022-04-11T16:52:03.047Z]     value = self.visit(child)
[task 2022-04-11T16:52:03.047Z]   File "/builds/worker/checkouts/gecko/testing/web-platform/tests/tools/wptrunner/wptrunner/wptmanifest/node.py", line 7, in visit
[task 2022-04-11T16:52:03.047Z]     return func(node)
[task 2022-04-11T16:52:03.047Z]   File "/builds/worker/checkouts/gecko/testing/web-platform/tests/tools/wptrunner/wptrunner/wptmanifest/backends/static.py", line 44, in visit_ConditionalNode
[task 2022-04-11T16:52:03.047Z]     if self.visit(node.children[0]):
[task 2022-04-11T16:52:03.047Z]   File "/builds/worker/checkouts/gecko/testing/web-platform/tests/tools/wptrunner/wptrunner/wptmanifest/node.py", line 7, in visit
[task 2022-04-11T16:52:03.047Z]     return func(node)
[task 2022-04-11T16:52:03.047Z]   File "/builds/worker/checkouts/gecko/testing/web-platform/tests/tools/wptrunner/wptrunner/wptmanifest/backends/static.py", line 75, in visit_BinaryExpressionNode
[task 2022-04-11T16:52:03.047Z]     operand_1 = self.visit(node.children[2])
[task 2022-04-11T16:52:03.047Z]   File "/builds/worker/checkouts/gecko/testing/web-platform/tests/tools/wptrunner/wptrunner/wptmanifest/node.py", line 7, in visit
[task 2022-04-11T16:52:03.047Z]     return func(node)
[task 2022-04-11T16:52:03.047Z]   File "/builds/worker/checkouts/gecko/testing/web-platform/tests/tools/wptrunner/wptrunner/wptmanifest/backends/static.py", line 75, in visit_BinaryExpressionNode
[task 2022-04-11T16:52:03.047Z]     operand_1 = self.visit(node.children[2])
[task 2022-04-11T16:52:03.047Z]   File "/builds/worker/checkouts/gecko/testing/web-platform/tests/tools/wptrunner/wptrunner/wptmanifest/node.py", line 7, in visit
[task 2022-04-11T16:52:03.047Z]     return func(node)
[task 2022-04-11T16:52:03.047Z]   File "/builds/worker/checkouts/gecko/testing/web-platform/tests/tools/wptrunner/wptrunner/wptmanifest/backends/static.py", line 54, in visit_VariableNode
[task 2022-04-11T16:52:03.047Z]     value = self.expr_data[node.data]
[task 2022-04-11T16:52:03.047Z] KeyError: 'isolated_process'
[task 2022-04-11T16:52:03.047Z] > /builds/worker/checkouts/gecko/testing/web-platform/tests/tools/wptrunner/wptrunner/wptmanifest/backends/static.py(54)visit_VariableNode()
[task 2022-04-11T16:52:03.047Z] -> value = self.expr_data[node.data]

[taskcluster:error] Task timeout after 2700 seconds. Force killing container.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

the unittests needed the new variable- doing a bit more testing, then will reland with the updated metadata for the wpt-fission tests

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/926510c7a2e4
add isolated-process flag to mozinfo.json. r=whimboo,webdriver-reviewers

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/926510c7a2e4

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/1b4903a6670f