Closed Bug 1763512 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33541 - [FlexNG] Update total_intrinsic_block_size_ for all expansion

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
101 Branch
Tracking Flags:
Tracking Status
firefox101 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33541 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33541
Details from upstream follow.

Alison Maher <almaher@microsoft.com> wrote:

[FlexNG] Update total_intrinsic_block_size_ for all expansion

Previously, we would not include expansion of the last flex row
in the total_intrinsic_block_size_ calculation. This was discovered
in CL:3551497 since the OOF static position calculation relies
on total_intrinsic_block_size_ (as opposed to intrinsic_block_size_
which is specific to the current fragmentainer and was already correct).

To fix the issue with total_intrinsic_block_size_, don't use
the line expansion to calculate the updated size, but use
intrinsic_block_size_ to calculate how total_intrinsic_block_size_
should be updated.

Bug: 660611
Change-Id: I154e3f82314c0e8aa3085d967098bef0fdb25dd7
Reviewed-on: https://chromium-review.googlesource.com/3574399
WPT-Export-Revision: a306f413f8262d7c9594c79fd0036bb76f5bdafe

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

FAIL: 2

Chrome

PASS: 1
FAIL: 1

Safari

PASS: 1
FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-break/flexbox/single-line-row-flex-fragmentation-033.html: FAIL

New Tests That Don't Pass

/css/css-break/flexbox/multi-line-row-flex-fragmentation-058.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/single-line-row-flex-fragmentation-033.html: FAIL (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eca2bc3d91ca
[wpt PR 33541] - [FlexNG] Update total_intrinsic_block_size_ for all expansion, a=testonly
https://hg.mozilla.org/integration/autoland/rev/b2a6ed0c0426
[wpt PR 33541] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/eca2bc3d91ca
https://hg.mozilla.org/mozilla-central/rev/b2a6ed0c0426

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox101: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
You need to log in before you can comment on or make changes to this bug.