1763586 - Remove Element from LoadScript.h

Status: RESOLVED FIXED

(DevTools :: Debugger, task, P3)

Description

[Yulia Startsev [:yulia] OOO until July 2026]

As of https://bugzilla.mozilla.org/show_bug.cgi?id=1751203, we have no more consumers of this data on the loadScript, so the debugger specific code can be removed.

Comment 1

[Yulia Startsev [:yulia] OOO until July 2026]

Attachment: Bug 1763586 - Adjust ScriptFetchOptions to be more accurate; r=jonco

Comment 2

[Yulia Startsev [:yulia] OOO until July 2026]

Attachment: Bug 1763586 - Clean up ScriptLoadContext now that it takes no args; r=jonco

Depends on D143137

Comment 3

[Yulia Startsev [:yulia] OOO until July 2026]

Attachment: Bug 1763586 - Remove Element from LoadScript and child classes; r=jonco!,ochameau

Depends on D143138

Comment 4

[Yulia Startsev [:yulia] OOO until July 2026]

Attachment: Bug 1763586 - remove jit tests for source element behavior; r=jonco

Depends on D143139

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/365eff56ce0f
Adjust ScriptFetchOptions to be more accurate; r=jonco
https://hg.mozilla.org/integration/autoland/rev/3fc84237decb
Remove Element from LoadScript and child classes; r=jonco
https://hg.mozilla.org/integration/autoland/rev/02a961432a49
remove jit tests for source element behavior; r=jonco

Comment 6

[Marian-Vasile Laza]

Backed out 3 changesets (Bug 1763586) foar causing sm bustages.
Backout link
Push with failures
Failure Log
Jit-1proc Failure Log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0294a6f9f9f
Adjust ScriptFetchOptions to be more accurate; r=jonco
https://hg.mozilla.org/integration/autoland/rev/ca0157c919a9
Remove Element from LoadScript and child classes; r=jonco
https://hg.mozilla.org/integration/autoland/rev/f6b6ccfce3d1
remove jit tests for source element behavior; r=jonco

Comment 8

[Iulian Moraru]

Backed out for causing mochitest-chrome failures on test_Debugger.Source.prototype.element.html.

Push with failures

Failure log

Backout link

[task 2022-04-13T18:09:52.497Z] 18:09:52     INFO - TEST-START | devtools/server/tests/chrome/test_Debugger.Source.prototype.element.html
[task 2022-04-13T18:09:52.499Z] 18:09:52     INFO - GECKO(1573) | [Parent 1573, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/chrome/nsChromeRegistry.cpp:180
[task 2022-04-13T18:09:52.499Z] 18:09:52     INFO - GECKO(1573) | [Parent 1573, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/dom/security/nsCSPService.cpp:190
[task 2022-04-13T18:09:52.518Z] 18:09:52     INFO - GECKO(1573) | [Parent 1573, Main Thread] WARNING: Failed to retarget HTML data delivery to the parser thread.: file /builds/worker/checkouts/gecko/parser/html/nsHtml5StreamParser.cpp:1198
[task 2022-04-13T18:09:52.571Z] 18:09:52     INFO - GECKO(1573) | [Parent 1573, Main Thread] WARNING: NS_ENSURE_TRUE(presShell) failed: file /builds/worker/checkouts/gecko/dom/base/nsGlobalWindowOuter.cpp:4145
[task 2022-04-13T18:09:52.581Z] 18:09:52     INFO - GECKO(1573) | [Parent 1573, Main Thread] WARNING: Failed to retarget HTML data delivery to the parser thread.: file /builds/worker/checkouts/gecko/parser/html/nsHtml5StreamParser.cpp:1198
[task 2022-04-13T18:09:52.613Z] 18:09:52     INFO - TEST-INFO | started process screencapture
[task 2022-04-13T18:09:52.698Z] 18:09:52     INFO - TEST-INFO | screencapture: exit 0
[task 2022-04-13T18:09:52.698Z] 18:09:52     INFO - Buffered messages logged at 18:09:52
[task 2022-04-13T18:09:52.699Z] 18:09:52     INFO - TEST-PASS | devtools/server/tests/chrome/test_Debugger.Source.prototype.element.html | top frame is franz 
[task 2022-04-13T18:09:52.699Z] 18:09:52     INFO - Buffered messages finished
[task 2022-04-13T18:09:52.700Z] 18:09:52     INFO - TEST-UNEXPECTED-FAIL | devtools/server/tests/chrome/test_Debugger.Source.prototype.element.html | top frame source belongs to element franz 
[task 2022-04-13T18:09:52.700Z] 18:09:52     INFO - SimpleTest.ok@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:417:16
[task 2022-04-13T18:09:52.700Z] 18:09:52     INFO - franzDebuggerHandler@chrome://mochitests/content/chrome/devtools/server/tests/chrome/test_Debugger.Source.prototype.element.html:59:7
[task 2022-04-13T18:09:52.700Z] 18:09:52     INFO - franz@chrome://mochitests/content/chrome/devtools/server/tests/chrome/Debugger.Source.prototype.element.html:9:5
[task 2022-04-13T18:09:52.700Z] 18:09:52     INFO - heinrichFun@chrome://mochitests/content/chrome/devtools/server/tests/chrome/Debugger.Source.prototype.element.js:6:3
[task 2022-04-13T18:09:52.700Z] 18:09:52     INFO - onclick@chrome://mochitests/content/chrome/devtools/server/tests/chrome/Debugger.Source.prototype.element.html:1:1
[task 2022-04-13T18:09:52.700Z] 18:09:52     INFO - onLoadHandler@chrome://mochitests/content/chrome/devtools/server/tests/chrome/test_Debugger.Source.prototype.element.html:51:33
[task 2022-04-13T18:09:52.701Z] 18:09:52     INFO - TEST-PASS | devtools/server/tests/chrome/test_Debugger.Source.prototype.element.html | top frame source doesn't belong to an attribute 
[task 2022-04-13T18:09:52.701Z] 18:09:52     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-04-13T18:09:52.702Z] 18:09:52     INFO - TEST-UNEXPECTED-FAIL | devtools/server/tests/chrome/test_Debugger.Source.prototype.element.html | second frame source belongs to element heinrich 
[task 2022-04-13T18:09:52.702Z] 18:09:52     INFO - SimpleTest.ok@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:417:16
[task 2022-04-13T18:09:52.702Z] 18:09:52     INFO - franzDebuggerHandler@chrome://mochitests/content/chrome/devtools/server/tests/chrome/test_Debugger.Source.prototype.element.html:65:7
[task 2022-04-13T18:09:52.702Z] 18:09:52     INFO - franz@chrome://mochitests/content/chrome/devtools/server/tests/chrome/Debugger.Source.prototype.element.html:9:5
[task 2022-04-13T18:09:52.703Z] 18:09:52     INFO - heinrichFun@chrome://mochitests/content/chrome/devtools/server/tests/chrome/Debugger.Source.prototype.element.js:6:3
[task 2022-04-13T18:09:52.703Z] 18:09:52     INFO - onclick@chrome://mochitests/content/chrome/devtools/server/tests/chrome/Debugger.Source.prototype.element.html:1:1
[task 2022-04-13T18:09:52.703Z] 18:09:52     INFO - onLoadHandler@chrome://mochitests/content/chrome/devtools/server/tests/chrome/test_Debugger.Source.prototype.element.html:51:33
[task 2022-04-13T18:09:52.703Z] 18:09:52     INFO - TEST-PASS | devtools/server/tests/chrome/test_Debugger.Source.prototype.element.html | second frame source doesn't belong to an attribute 
[task 2022-04-13T18:09:52.703Z] 18:09:52     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-04-13T18:09:52.704Z] 18:09:52     INFO - TEST-UNEXPECTED-FAIL | devtools/server/tests/chrome/test_Debugger.Source.prototype.element.html | third frame source belongs to element heidi 
[task 2022-04-13T18:09:52.705Z] 18:09:52     INFO - SimpleTest.ok@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:417:16
[task 2022-04-13T18:09:52.705Z] 18:09:52     INFO - franzDebuggerHandler@chrome://mochitests/content/chrome/devtools/server/tests/chrome/test_Debugger.Source.prototype.element.html:71:7
[task 2022-04-13T18:09:52.705Z] 18:09:52     INFO - franz@chrome://mochitests/content/chrome/devtools/server/tests/chrome/Debugger.Source.prototype.element.html:9:5
[task 2022-04-13T18:09:52.705Z] 18:09:52     INFO - heinrichFun@chrome://mochitests/content/chrome/devtools/server/tests/chrome/Debugger.Source.prototype.element.js:6:3
[task 2022-04-13T18:09:52.705Z] 18:09:52     INFO - onclick@chrome://mochitests/content/chrome/devtools/server/tests/chrome/Debugger.Source.prototype.element.html:1:1
[task 2022-04-13T18:09:52.705Z] 18:09:52     INFO - onLoadHandler@chrome://mochitests/content/chrome/devtools/server/tests/chrome/test_Debugger.Source.prototype.element.html:51:33
[task 2022-04-13T18:09:52.705Z] 18:09:52     INFO - TEST-PASS | devtools/server/tests/chrome/test_Debugger.Source.prototype.element.html | third frame source belongs to 'onclick' attribute 
<...>

Comment 9

[Yulia Startsev [:yulia] OOO until July 2026]

Attachment: Bug 1763586 - remove debugger tests for source element behavior; r=ochameau

Depends on D143140

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68cd444d018e
Adjust ScriptFetchOptions to be more accurate; r=jonco
https://hg.mozilla.org/integration/autoland/rev/420105516ec3
Remove Element from LoadScript and child classes; r=jonco
https://hg.mozilla.org/integration/autoland/rev/8f964a9e2f31
remove jit tests for source element behavior; r=jonco
https://hg.mozilla.org/integration/autoland/rev/8da9574159d3
remove debugger tests for source element behavior; r=ochameau

Comment 11

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing mochitest failures on test_Debugger.Source.prototype.elementAttribute.html

Backout link : https://hg.mozilla.org/integration/autoland/rev/c554d1b188f4f4441afbee2e0e545a96034e805d

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=d5kVCS5ASE2hbHKjRPaEiw.0&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Cdebug%2Cmochitests%2Cwith%2Cnetworking%2Con%2Csocket%2Cprocess%2Cwithout%2Ce10s%2Ctest-linux1804-64-qr%2Fdebug-mochitest-chrome-spi-nw-1proc%2Cc2&revision=8da9574159d36adb31163300f822fbfbe8b96af9

Link to failure log : https://treeherder.mozilla.org/logviewer?job_id=374979977&repo=autoland&lineNumber=2547

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47f3be428da1
Adjust ScriptFetchOptions to be more accurate; r=jonco
https://hg.mozilla.org/integration/autoland/rev/bf91a2e0c4e5
Remove Element from LoadScript and child classes; r=jonco
https://hg.mozilla.org/integration/autoland/rev/4bf4d7fff068
remove jit tests for source element behavior; r=jonco
https://hg.mozilla.org/integration/autoland/rev/d59220cc1142
remove debugger tests for source element behavior; r=ochameau

Comment 13

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/47f3be428da1
https://hg.mozilla.org/mozilla-central/rev/bf91a2e0c4e5
https://hg.mozilla.org/mozilla-central/rev/4bf4d7fff068
https://hg.mozilla.org/mozilla-central/rev/d59220cc1142