1763642 - Assertion failure: false (MOZ_ASSERT_UNREACHABLE: Stale blob image key (delete)!), at /builds/worker/checkouts/gecko/gfx/layers/wr/WebRenderBridgeParent.cpp:675

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

[task 2022-04-07T14:51:38.783Z] 14:51:38     INFO - REFTEST TEST-START | layout/tables/crashtests/750147.html
[task 2022-04-07T14:51:38.817Z] 14:51:38     INFO - REFTEST INFO | SET PREFERENCE pref(font.size.inflation.minTwips,120)
[task 2022-04-07T14:51:38.819Z] 14:51:38     INFO - REFTEST TEST-LOAD | file:///builds/worker/workspace/build/tests/reftest/tests/layout/tables/crashtests/750147.html | 3736 / 3941 (94%)
[task 2022-04-07T14:51:38.887Z] 14:51:38     INFO - Assertion failure: false (MOZ_ASSERT_UNREACHABLE: Stale blob image key (delete)!), at /builds/worker/checkouts/gecko/gfx/layers/wr/WebRenderBridgeParent.cpp:675
[task 2022-04-07T14:51:38.889Z] 14:51:38     INFO - #01: mozilla::layers::WebRenderBridgeParent::UpdateResources(nsTArray<mozilla::layers::OpUpdateResource> const&, nsTArray<mozilla::layers::RefCountedShmem> const&, nsTArray<mozilla::ipc::Shmem> const&, mozilla::wr::TransactionBuilder&) [gfx/layers/wr/WebRenderBridgeParent.cpp:675]
[task 2022-04-07T14:51:38.893Z] 14:51:38     INFO - #02: mozilla::layers::WebRenderBridgeParent::SetDisplayList(mozilla::gfx::RectTyped<mozilla::LayoutDevicePixel, float> const&, mozilla::ipc::ByteBuf&&, mozilla::ipc::ByteBuf&&, mozilla::ipc::ByteBuf&&, mozilla::wr::BuiltDisplayListDescriptor const&, nsTArray<mozilla::layers::OpUpdateResource> const&, nsTArray<mozilla::layers::RefCountedShmem> const&, nsTArray<mozilla::ipc::Shmem> const&, mozilla::TimeStamp const&, mozilla::wr::TransactionBuilder&, mozilla::wr::Epoch, bool) [gfx/layers/wr/WebRenderBridgeParent.cpp:1119]
[task 2022-04-07T14:51:38.896Z] 14:51:38     INFO - #03: mozilla::layers::WebRenderBridgeParent::ProcessDisplayListData(mozilla::layers::DisplayListData&, mozilla::wr::Epoch, mozilla::TimeStamp const&, bool, bool) [gfx/layers/wr/WebRenderBridgeParent.cpp:1184]
[task 2022-04-07T14:51:38.896Z] 14:51:38     INFO - #04: mozilla::layers::WebRenderBridgeParent::RecvSetDisplayList(mozilla::layers::DisplayListData&&, nsTArray<mozilla::layers::OpDestroy>&&, unsigned long const&, mozilla::layers::BaseTransactionId<mozilla::layers::TransactionIdType> const&, bool const&, mozilla::layers::BaseTransactionId<mozilla::VsyncIdType> const&, mozilla::TimeStamp const&, mozilla::TimeStamp const&, mozilla::TimeStamp const&, nsTString<char> const&, mozilla::TimeStamp const&, nsTArray<mozilla::layers::CompositionPayload>&&) [gfx/layers/wr/WebRenderBridgeParent.cpp:1243]
[task 2022-04-07T14:51:38.897Z] 14:51:38     INFO - #05: mozilla::layers::PWebRenderBridgeParent::OnMessageReceived(IPC::Message const&) [s3:gecko-generated-sources-l1:cd7de132230c6b0ab84ff5f9a239a52d0d9bbada5bd2f17bf8f837a4f0747edd57a9be2d5cf0cc0e9f5e8daad93cc6ef46d9ca0afe2afd237460c264697e7f82/ipc/ipdl/PWebRenderBridgeParent.cpp::458]
[task 2022-04-07T14:51:38.900Z] 14:51:38     INFO - #06: mozilla::layers::PCompositorManagerParent::OnMessageReceived(IPC::Message const&) [s3:gecko-generated-sources-l1:97eaef712a457c44c491ff0267e805ccc32bcc066639c855751b819f53759a42fa5e2b5c5e2743c2df35bd36a73d903437794b330f7b9481d61fa5f0e9fb94ff/ipc/ipdl/PCompositorManagerParent.cpp::193]
[task 2022-04-07T14:51:38.902Z] 14:51:38     INFO - #07: mozilla::ipc::MessageChannel::DispatchAsyncMessage(mozilla::ipc::ActorLifecycleProxy*, IPC::Message const&) [ipc/glue/MessageChannel.cpp:1707]
[task 2022-04-07T14:51:38.904Z] 14:51:38     INFO - #08: mozilla::ipc::MessageChannel::DispatchMessage(mozilla::ipc::ActorLifecycleProxy*, IPC::Message&&) [ipc/glue/MessageChannel.cpp:1635]
[task 2022-04-07T14:51:38.907Z] 14:51:38     INFO - #09: mozilla::ipc::MessageChannel::RunMessage(mozilla::ipc::ActorLifecycleProxy*, mozilla::ipc::MessageChannel::MessageTask&) [ipc/glue/MessageChannel.cpp:1493]
[task 2022-04-07T14:51:38.908Z] 14:51:38     INFO - #10: mozilla::ipc::MessageChannel::MessageTask::Run() [ipc/glue/MessageChannel.cpp:1530]
[task 2022-04-07T14:51:38.910Z] 14:51:38     INFO - #11: nsThread::ProcessNextEvent(bool, bool*) [xpcom/threads/nsThread.cpp:1182]
[task 2022-04-07T14:51:38.912Z] 14:51:38     INFO - #12: NS_ProcessNextEvent(nsIThread*, bool) [xpcom/threads/nsThreadUtils.cpp:465]
[task 2022-04-07T14:51:38.913Z] 14:51:38     INFO - #13: mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:330]
[task 2022-04-07T14:51:38.915Z] 14:51:38     INFO - #14: MessageLoop::RunInternal() [ipc/chromium/src/base/message_loop.cc:380]
[task 2022-04-07T14:51:38.915Z] 14:51:38     INFO - #15: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:356]
[task 2022-04-07T14:51:38.916Z] 14:51:38     INFO - #16: nsThread::ThreadFunc(void*) [xpcom/threads/nsThread.cpp:387]
[task 2022-04-07T14:51:38.941Z] 14:51:38     INFO - #17: _pt_root [nsprpub/pr/src/pthreads/ptthread.c:204]
[task 2022-04-07T14:51:38.949Z] 14:51:38     INFO - #18: set_alt_signal_stack_and_start(PthreadCreateParams*) [/builds/worker/workspace/build/application/firefox/firefox + 0xe5513]
[task 2022-04-07T14:51:38.950Z] 14:51:38     INFO - #19: ??? [/lib/x86_64-linux-gnu/libpthread.so.0 + 0x76db]
[task 2022-04-07T14:51:38.952Z] 14:51:38     INFO - #20: clone [/lib/x86_64-linux-gnu/libc.so.6 + 0x121a3f]
[task 2022-04-07T14:51:38.953Z] 14:51:38     INFO - #21: ??? (???:???)

https://treeherder.mozilla.org/logviewer?job_id=373739640&repo=try&lineNumber=173944

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1763642 - Fix assertion where we try to free stale blob keys.

We get consistent crashtest failures in CI when image.svg.blob-image
is set to true. This is because on some teardown paths, we don't verify
to see if the layer manager still owns the namespace used for the blob
keys.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d61c0e3b61d
Fix assertion where we try to free stale blob keys. r=gfx-reviewers,lsalzman

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/3d61c0e3b61d