Closed
Bug 1763686
Opened 3 years ago
Closed 3 years ago
Reduce default subtitles font size setting
Categories
(Toolkit :: Picture-in-Picture, enhancement, P2)
Toolkit
Picture-in-Picture
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox100 | --- | fixed |
| firefox101 | --- | unaffected |
People
(Reporter: asafko, Assigned: niklas)
References
Details
(Whiteboard: [fidefe-MR1-2022])
Attachments
(1 file)
|
48 bytes,
text/x-phabricator-request
|
diannaS
:
approval-mozilla-beta+
|
Details | Review |
Let's please ship the reduced subtitles font size that was a part of this 101 patch in 100
Updated•3 years ago
|
| Assignee | ||
Comment 1•3 years ago
|
||
| Assignee | ||
Comment 2•3 years ago
|
||
Comment on attachment 9271352 [details]
Bug 1763686 - Reduce default subtitles font size. r=#pip-reviewers!
Beta/Release Uplift Approval Request
- User impact if declined: We need this change in 100 for the PiP in Firefox 100 Release.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This change is very low risk. This change is only a minor CSS change and the change already exists in Nightly now. This bug is only to uplift these changes to 100 so it is present in PiP for Firefox 100 Release.
- String changes made/needed: No
Attachment #9271352 -
Flags: approval-mozilla-beta?
Comment 3•3 years ago
|
||
Comment on attachment 9271352 [details]
Bug 1763686 - Reduce default subtitles font size. r=#pip-reviewers!
Approved for 100.0b5
Attachment #9271352 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 4•3 years ago
|
||
| bugherder uplift | ||
status-firefox100:
--- → fixed
| Assignee | ||
Comment 5•3 years ago
|
||
This fix has already landed in nightly from bug 1757219. We just need to uplift to to beta.
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox101:
--- → unaffected
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•