Closed Bug 1763723 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33560 - [FlexNG] IsBreakableAtStartOfResumedContainer for flex rows

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
101 Branch
Tracking Flags:
Tracking Status
firefox101 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33560 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33560
Details from upstream follow.

Alison Maher <almaher@microsoft.com> wrote:

[FlexNG] IsBreakableAtStartOfResumedContainer for flex rows

We used to use the first child layout result of a row to determine
IsBreakableAtStartOfResumedContainer() for the row. However, since
items can break before multiple times, a row might not be the
first for the node while the first item in the row is.

Pass is_first_for_node as an input to
IsBreakableAtStartOfResumedContainer() so that we can use the value
specific to the row instead of its item.

The test I added works with and without this CL, but I wasn't able
to think of a case where this actually broke anything.

Bug: 660611
Change-Id: I9cbbd61c383dac0ce149d9f33f8c2b82b983a1d9
Reviewed-on: https://chromium-review.googlesource.com/3575366
WPT-Export-Revision: d7731824679e73d4c9d84a3cf900fb041986bc85

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-break/flexbox/multi-line-row-flex-fragmentation-059.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0e096a5b46fc
[wpt PR 33560] - [FlexNG] IsBreakableAtStartOfResumedContainer for flex rows, a=testonly
https://hg.mozilla.org/integration/autoland/rev/455c5db475e6
[wpt PR 33560] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/0e096a5b46fc
https://hg.mozilla.org/mozilla-central/rev/455c5db475e6

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox101: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
You need to log in before you can comment on or make changes to this bug.