1763742 - LOCAL_GL_PACK_ALIGNMENT is sometimes used with functions other than glReadPixels

Status: RESOLVED FIXED

(Core :: Graphics, task, P3)

Description

[Kelsey Gilbert [:jgilbert]]

glPixelStorei(GL_PACK_ALIGNMENT, 1); only changes behavior of glReadPixels (and glGetTexImage), but we have some uses where it appears to be set erroneously/spuriously:

• https://searchfox.org/mozilla-central/rev/fc5c4461124b8572442c71bc34947bee68b75551/gfx/layers/NativeLayerCA.mm#715
• https://searchfox.org/mozilla-central/rev/fc5c4461124b8572442c71bc34947bee68b75551/gfx/layers/NativeLayerCA.mm#1710
• https://searchfox.org/mozilla-central/rev/fc5c4461124b8572442c71bc34947bee68b75551/gfx/layers/opengl/CompositorOGL.cpp#84

Comment 1

[Kelsey Gilbert [:jgilbert]]

To be clear: This is harmless, except that it looks like it gives the wrong impression that it does something useful.

Comment 2

[Bob Hood [:bhood]]

Attachment: Bug 1763742: Removed remaining lines as suggested.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bb82230a3bd3
https://hg.mozilla.org/integration/autoland/rev/29d0e0ff0d05
Removed remaining lines as suggested. r=gfx-reviewers,bradwerth

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/29d0e0ff0d05