1763782 - HDR video playback support does not work for AV1 codec

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Alin Ilea, Desktop QA]

Attachment: Screenshot 2022-04-08 at 12.04.43.png

Affected Versions:

Nightly 101.0a1, Beta 100.0b3 (this feature was implemented in Fx100, in Release 99 it is disabled).

Tested on:

macOS 12.3 (iMac Retina 4k, 16-inch, 2019)
macOS 11 (MacBook Pro 16-inch, 2019)

Preconditions:

Access: https://drive.google.com/drive/u/0/folders/1S-E4WeKO6y6UySHnSWvfAuCB7N6URdCj and download the files locally on your computer.

Steps to reproduce:

1. Launch Firefox.
2. Open a new tab and drag&drop the "Sparks-5994fps-AV1-10bit-1920x1080-2194kbps.webm" or "all_in_one_hdr.mp4" (both are AV1) video saved in preconditions, from the computer to FF window.
3. Play the video.

Expected Results:

The video should play in HDR.

Actual Results:

The video is not playing in HDR mode.

Comment 1

[Brad Werth [:bradwerth]]

Attachment: Bug 1763782 Part 1: Allow AV1 10-bit to be decoded.

This stubs in decode support for 10-bit AV1. The result has the right
proportion but is color-shifted, indicating that the packing of the data
doesn't match the expectations of the P010 format, which is a MSB format.
So probably each uint16 needs to be left-shifted 6 bits.

Comment 2

[Brad Werth [:bradwerth]]

Attachment: Bug 1763782 Part 2: Set color primaries and transfer functions for HD and HDR.

This derives sane values for color primaries and transfer functions from
the colorspace value. A better solution would be to extract those values
from the video itself, but these are good enough for common encodings and
match the behavior for hardware-decoded video in AppleVTDecoder.

Depends on D143436

Comment 3

[Brad Werth [:bradwerth]]

Attachment: Bug 1763782 Part 3: Update test expectations.

Depends on D143542

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f02711a485f
Part 1: Allow AV1 10-bit to be decoded. r=gfx-reviewers,jgilbert
https://hg.mozilla.org/integration/autoland/rev/fefcfb0559bf
Part 2: Set color primaries and transfer functions for HD and HDR. r=gfx-reviewers,jgilbert
https://hg.mozilla.org/integration/autoland/rev/b38b90bc7a4d
Part 3: Update test expectations. r=jgilbert,gfx-reviewers

Comment 5

[Cristian Tuns]

Backed out for causing reftest failures.

• Backout link
• Push with failures
• Failure Log
  log 2: https://treeherder.mozilla.org/logviewer?job_id=374696200&repo=autoland
• Failure line: REFTEST TEST-UNEXPECTED-FAIL | dom/media/test/reftest/color_quads/720p.png.bt709.bt709.tv.yuv420p10.av1.webm == dom/media/test/reftest/color_quads/720p.png | image comparison, max difference: 74, number of differing pixels: 270487

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e39c412b7041
Part 1: Allow AV1 10-bit to be decoded. r=gfx-reviewers,jgilbert
https://hg.mozilla.org/integration/autoland/rev/0ad6c07468fa
Part 2: Set color primaries and transfer functions for HD and HDR. r=gfx-reviewers,jgilbert
https://hg.mozilla.org/integration/autoland/rev/424e46671d4f
Part 3: Update test expectations. r=jgilbert,gfx-reviewers

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e39c412b7041
https://hg.mozilla.org/mozilla-central/rev/0ad6c07468fa
https://hg.mozilla.org/mozilla-central/rev/424e46671d4f

Comment 8

[Alin Ilea, Desktop QA]

Verified - Fixed in latest Nightly 101.0a1 (2022-04-19), using macOS 12.3 and macOS 11. The AV1 video is properly rendered in HDR.

Comment 9

[Brad Werth [:bradwerth]]

Comment on attachment 9271828 [details]
Bug 1763782 Part 1: Allow AV1 10-bit to be decoded.

Beta/Release Uplift Approval Request

• User impact if declined: HDR capability reporting is in-tree, but support for AV1 is not. Users might get served HDR AV1 content by YouTube and get a bad visual experience.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1765396
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This has been tested thoroughly by QA. It is also "merely" a visual fidelity feature and has not led to any blocking problems.
• String changes made/needed:
• Is Android affected?: No

Comment 10

[Dianna Smith [:diannaS]]

Comment on attachment 9271828 [details]
Bug 1763782 Part 1: Allow AV1 10-bit to be decoded.

Approved for 100.0b9

Comment 11

[Brad Werth [:bradwerth]]

Dianna, as mentioned in the request, Bug 1765396 should travel with it. Can you mark that approved for uplift as well?

Comment 12

[Dianna Smith [:diannaS]]

yes, i was waiting on the nomination before the push, but that is complete now.

Comment 13

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2dafc68ee3a8
https://hg.mozilla.org/releases/mozilla-beta/rev/2b26abea360a
https://hg.mozilla.org/releases/mozilla-beta/rev/644d2f14fb7b

Comment 14

[Alin Ilea, Desktop QA]

Verified - Fixed in latest Beta 100.0 (build id: 20220425210429). The AV1 video is properly rendered in HDR.