1763943 - Run `new Function("a", "b", "a+b")` in Browser Console causes an Error in Nightly build

Status: VERIFIED FIXED

(DevTools :: Console, defect)

Description

[Alice0775 White]

Steps to reproduce:

1. Open Browser Console
2. Run new Function("a", "b", "a+b") in the console

Actual Results:
Fails to create the new function due to the following Error.

Uncaught InternalError: unsafe filename: debugger eval code line 1 > Function
    <anonymous> debugger eval code:1
    getEvalResult resource://devtools/server/actors/webconsole/eval-with-debugger.js:243
    evalWithDebugger resource://devtools/server/actors/webconsole/eval-with-debugger.js:167
    evaluateJS resource://devtools/server/actors/webconsole.js:1115
    evaluateJSAsync resource://devtools/server/actors/webconsole.js:1007
    makeInfallible resource://devtools/shared/ThreadSafeDevToolsUtils.js:103
debugger eval code:1:1
    <anonymous> debugger eval code:1

Expected Results:
Successfully created.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?&tochange=ecd05de39436&fromchange=322e753a4898

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:tjr, since you are the author of the regressor, bug 1742645, could you take a look?
For more information, please visit auto_nag documentation.

Comment 2

[Simon Mainey]

FWIW worksforme Windows 7 (nightly)

Comment 3

[Alice0775 White]

This can also be reproduced on Nightly101.0a1 Ubuntu 20.04.

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I can reproduce on the latest m-c Fx101 build (Win10)
Works for me in Fx99 (Win10)

Comment 5

[Alice0775 White]

The regressionwindow, See comment#0

Comment 6

[Alice0775 White]

FWIW, setting security.allow_parent_unrestricted_js_loads to true solves this.

Comment 7

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1763943: Do not bust on the debugger filename in the Browser Console r?ckerschb

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94ee875dee20
Do not bust on the debugger filename in the Browser Console r=ckerschb

Comment 9

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/94ee875dee20

Comment 10

[Hani Yacoub, Desktop QA]

Verified as fixed on Windows 10 x64, Ubuntu 20.04 x64 and on macOS 11.6 on Firefox 102.0b3 and Nightly 103.0a1.