1764097 - Crash in [@ mozilla::dom::quota::QuotaManager::Shutdown::<T>::__invoke]

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, defect)

Description

[Calixte Denizet (:calixte)]

Maybe Fission related. (DOMFissionEnabled=1)

Crash report: https://crash-stats.mozilla.org/report/index/429d9ace-c4a4-45f4-8422-93ac20220408

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames of crashing thread:

0 xul.dll static mozilla::dom::quota::QuotaManager::Shutdown::<lambda_0>::__invoke dom/quota/ActorsParent.cpp:3837
1 xul.dll nsTimerImpl::Fire xpcom/threads/nsTimerImpl.cpp:661
2 xul.dll nsTimerEvent::Run xpcom/threads/TimerThread.cpp:265
3 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1181
4 xul.dll nsThread::Shutdown xpcom/threads/nsThread.cpp:882
5 xul.dll mozilla::dom::quota::QuotaManager::Shutdown dom/quota/ActorsParent.cpp:4013
6 xul.dll static mozilla::dom::quota::QuotaManager::ShutdownInstance dom/quota/ActorsParent.cpp:3381
7 xul.dll mozilla::dom::quota::RecvShutdownQuotaManager dom/quota/ActorsParent.cpp:2766
8 xul.dll mozilla::ipc::BackgroundParentImpl::RecvShutdownQuotaManager ipc/glue/BackgroundParentImpl.cpp:1103
9 xul.dll mozilla::ipc::PBackgroundParent::OnMessageReceived ipc/ipdl/PBackgroundParent.cpp:4869

There are 15 crashes (from 14 installations) in nightly 101 starting with buildid 20220408094506. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1757186.

[1] https://hg.mozilla.org/mozilla-central/rev?node=971e1a26ebfe

Comment 1

[Jens Stutte [:jstutte]]

This is just a signature change.

Comment 2

[Jens Stutte [:jstutte]]

(In reply to Jens Stutte [:jstutte] from comment #1)

This is just a signature change.

*** This bug has been marked as a duplicate of bug 1588498 ***

Actually I was wrong: This was a real regression.

Comment 3

[Jens Stutte [:jstutte]]

Attachment: Bug 1764097: Try to add pending operations annotation only if we have some. r?#dom-storage-reviewers

Comment 4

[Phabricator Automation]

Comment on attachment 9273822 [details]
Bug 1764097: Try to add pending operations annotation only if we have some. r?#dom-storage-reviewers

Revision D144705 was moved to bug 1757186. Setting attachment 9273822 [details] to obsolete.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c8127e5bc4d
Try to add pending operations annotation only if we have some. r=dom-storage-reviewers,janv

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/0c8127e5bc4d

Comment 7

[Jens Stutte [:jstutte]]

It is expected to still see crashes from the same function, but now we have the here wanted annotations.