1764098 - Save to Pocket button on cards broken if Pocket is turned off

Status: VERIFIED FIXED

(Firefox :: Pocket, defect)

Description

[Scott [:thecount] Downe]

we have a pref to allow save to Pocket buttons above Pocket cards on newtab "browser.newtabpage.activity-stream.discoverystream.saveToPocketCard.enabled"

There is also a pref to turn off Pocket "extensions.pocket.enabled"

If Pocket is turned off we still display the save to Pocket button on cards, which is broken if you click it because there is no Pocket panel or Pocket save functionality.

Should turn off the feature if Pocket is disabled.

Comment 1

[Scott [:thecount] Downe]

Attachment: Bug 1764098 - Pocket newtab save to Pocket context menu items don't turn off if Pocket is turned off.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:thecount, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Scott [:thecount] Downe]

To test:

1. set extensions.pocket.enabled to false
2. load a newtab with Pocket stories.
3. Click the ... menu on a Pocket story.

Expected: Should not have a save to Pocket option in the context menu from the ... menu.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ba127f471e9
Pocket newtab save to Pocket context menu items don't turn off if Pocket is turned off. r=gvn

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/3ba127f471e9

Comment 6

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on Firefox 99.0 on Windows 10 x64. Verified as fixed on Firefox 102.0b4(20220605185654) and Nightly 103.0a1(20220606212503) on Windows 10 x64, macOS 11 and Ubuntu 20.04.