Closed Bug 1764102 Opened 2 years ago Closed 2 years ago

DOCUMENT_EVENT's dom-complete isn't fired when the page fails loading

Categories

(DevTools :: Framework, defect)

defect

Tracking

(firefox101 fixed)

RESOLVED FIXED
101 Branch
Tracking Status
firefox101 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

While trying to remove non-EFT codepath, I realized that DOCUMENT's dom-complete wasn't fired when the page was using window.stop().
This probably also mean that this event isn't fired when the page fails loading.
This is an error as navigate explicitely used to be fired in such scenario:
https://searchfox.org/mozilla-central/rev/0e93b94f4c2045c6a5f5260ee48bbf7a94a993bc/devtools/server/actors/targets/window-global.js#1900-1922

Not firing this event means that there is probably various features being broken when the page stops or fails loading.

Blocks: 1764179
Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f6957c10abb0
[devtools] Ensure firing dom-complete when the page pauses or fails loading. r=nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: