1764167 - [wpt-sync] Sync PR 33587 - Make CloseWatcher process escape key after default event handlers

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 33587 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33587
Details from upstream follow.

Joey Arhar <[e-mail]> wrote:

Make CloseWatcher process escape key after default event handlers

Before this patch, CloseWatcher processes the escape key before default
event handlers, which means that it takes precedence over all default
behavior of elements in the page when the escape key is pressed, such as
pressing escape on \<input type=search>.

This patch adds some plumbing to make CloseWatcher get the escape key
event after \<input type=search> does and check for defaults already
being handled.

Fixed: 1312594
Change-Id: I156e329c7c7ea0c8742c102b87c221d9ce10f4ed
Reviewed-on: https://chromium-review.googlesource.com/3570026
WPT-Export-Revision: 3a138cd2c07da289d3d266b2f21c5f088a39bff6

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=64631b4fdb62db7460e7ad89ac19fb4e1dc56a04

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL : 1

Chrome

ERROR: 1

Safari

OK : 1
FAIL : 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/close-watcher/after-other-listeners.html
normal event listeners come before CloseWatcher: FAIL (Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51e7ccd3a351
[wpt PR 33587] - Make CloseWatcher process escape key after default event handlers, a=testonly
https://hg.mozilla.org/integration/autoland/rev/d40b88552687
[wpt PR 33587] - Update wpt metadata, a=testonly

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/51e7ccd3a351
https://hg.mozilla.org/mozilla-central/rev/d40b88552687